[scheduler] Remove blink::scheduler::TaskQueue from public API.

third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef THIRD_PARTY_WEBKIT_SOURCE_PLATFORM_SCHEDULER_RENDERER_RENDERER_SCHEDULER_IMPL_H_
 #define THIRD_PARTY_WEBKIT_SOURCE_PLATFORM_SCHEDULER_RENDERER_RENDERER_SCHEDULER_IMPL_H_
 
 #include "base/atomicops.h"
 #include "base/gtest_prod_util.h"
 #include "base/macros.h"
 #include "base/synchronization/lock.h"
 #include "base/trace_event/trace_log.h"
 #include "device/base/synchronization/shared_memory_seqlock_buffer.h"
 #include "platform/scheduler/base/pollable_thread_safe_flag.h"
 #include "platform/scheduler/base/queueing_time_estimator.h"
+#include "platform/scheduler/base/task_time_observer.h"
 #include "platform/scheduler/base/thread_load_tracker.h"
 #include "platform/scheduler/child/idle_canceled_delayed_task_sweeper.h"
 #include "platform/scheduler/child/idle_helper.h"
 #include "platform/scheduler/child/scheduler_helper.h"
 #include "platform/scheduler/renderer/deadline_task_runner.h"
 #include "platform/scheduler/renderer/idle_time_estimator.h"
 #include "platform/scheduler/renderer/render_widget_signals.h"
 #include "platform/scheduler/renderer/task_cost_estimator.h"
 #include "platform/scheduler/renderer/user_model.h"
 #include "platform/scheduler/renderer/web_view_scheduler_impl.h"
 #include "public/platform/scheduler/renderer/renderer_scheduler.h"
-#include "public/platform/scheduler/base/task_time_observer.h"
 
 namespace base {
 namespace trace_event {
 class ConvertableToTraceFormat;
 }
 }
 
 namespace blink {
 namespace scheduler {
 class AutoAdvancingVirtualTimeDomain;
@@ skipping 40 matching lines @@
     FIRST_USE_CASE = NONE,
   };
   static const char* UseCaseToString(UseCase use_case);
   static const char* RAILModeToString(v8::RAILMode rail_mode);
 
   RendererSchedulerImpl(scoped_refptr<SchedulerTqmDelegate> main_task_runner);
   ~RendererSchedulerImpl() override;
 
   // RendererScheduler implementation:
   std::unique_ptr<WebThread> CreateMainThread() override;
-  scoped_refptr<TaskQueue> DefaultTaskRunner() override;
+  scoped_refptr<base::SingleThreadTaskRunner> DefaultTaskRunner() override;
   scoped_refptr<SingleThreadIdleTaskRunner> IdleTaskRunner() override;
-  scoped_refptr<TaskQueue> CompositorTaskRunner() override;
-  scoped_refptr<TaskQueue> LoadingTaskRunner() override;
-  scoped_refptr<TaskQueue> TimerTaskRunner() override;
-  scoped_refptr<TaskQueue> NewLoadingTaskRunner(
-      TaskQueue::QueueType queue_type) override;
-  scoped_refptr<TaskQueue> NewTimerTaskRunner(
-      TaskQueue::QueueType queue_type) override;
-  scoped_refptr<TaskQueue> NewUnthrottledTaskRunner(
-      TaskQueue::QueueType queue_type) override;
+  scoped_refptr<base::SingleThreadTaskRunner> CompositorTaskRunner() override;
+  scoped_refptr<base::SingleThreadTaskRunner> LoadingTaskRunner() override;
+  scoped_refptr<base::SingleThreadTaskRunner> TimerTaskRunner() override;
   std::unique_ptr<RenderWidgetSchedulingState> NewRenderWidgetSchedulingState()
       override;
   void WillBeginFrame(const cc::BeginFrameArgs& args) override;
   void BeginFrameNotExpectedSoon() override;
   void DidCommitFrameToCompositor() override;
   void DidHandleInputEventOnCompositorThread(
       const WebInputEvent& web_input_event,
       InputEventState event_state) override;
   void DidHandleInputEventOnMainThread(const WebInputEvent& web_input_event,
                                        WebInputEventResult result) override;
@@ skipping 34 matching lines @@
   // TaskTimeObserver implementation:
   void WillProcessTask(TaskQueue* task_queue, double start_time) override;
   void DidProcessTask(TaskQueue* task_queue,
                       double start_time,
                       double end_time) override;
   void OnBeginNestedMessageLoop() override;
 
   // QueueingTimeEstimator::Client implementation:
   void OnQueueingTimeForWindowEstimated(base::TimeDelta queueing_time) override;
 
+  // Blink clients should use RendereSchedulerImpl::*TaskQueue

[Sami, 2017/04/12 16:45:21]

This seems a little too confusing. Could we figure out a better interface?

[altimin, 2017/04/12 17:02:25]

Given that these methods are essentially the same (like GetRendererScheduler vs
GetRendererSchedulerImpl), one could think that it's fine.

[Sami, 2017/04/12 17:42:02]

Could we get away with just exposing TaskQueue here and have some other way of
letting content/ get at the underlying STTR? I think this is baking in a little
too many assumptions about how all this will be used.

[altimin, 2017/04/13 12:41:50]

Moved overriden methods to protected section.

+  // instead of RendererScheduler::*TaskRunner.
+  scoped_refptr<TaskQueue> DefaultTaskQueue();
+  scoped_refptr<TaskQueue> CompositorTaskQueue();
+  scoped_refptr<TaskQueue> LoadingTaskQueue();
+  scoped_refptr<TaskQueue> TimerTaskQueue();
+
+  // Returns a new loading task runner. This queue is intended for tasks related
+  // to resource dispatch, foreground HTML parsing, etc...
+  scoped_refptr<TaskQueue> NewLoadingTaskQueue(TaskQueue::QueueType queue_type);
+
+  // Returns a new timer task runner. This queue is intended for DOM Timers.
+  scoped_refptr<TaskQueue> NewTimerTaskQueue(TaskQueue::QueueType queue_type);
+
+  // Returns a task runner for tasks which should never get throttled.
+  scoped_refptr<TaskQueue> NewUnthrottledTaskQueue(
+      TaskQueue::QueueType queue_type);
+
   // Returns a task runner where tasks run at the highest possible priority.
-  scoped_refptr<TaskQueue> ControlTaskRunner();
+  scoped_refptr<TaskQueue> ControlTaskQueue();
 
   void RegisterTimeDomain(TimeDomain* time_domain);
   void UnregisterTimeDomain(TimeDomain* time_domain);
 
   // Tells the scheduler that all TaskQueues should use virtual time.
   void EnableVirtualTime();
 
   // Migrates all task queues to real time.
   void DisableVirtualTimeForTesting();
 
@@ skipping 366 matching lines @@
 
   base::WeakPtrFactory<RendererSchedulerImpl> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(RendererSchedulerImpl);
 };
 
 }  // namespace scheduler
 }  // namespace blink
 
 #endif  // THIRD_PARTY_WEBKIT_SOURCE_PLATFORM_SCHEDULER_RENDERER_RENDERER_SCHEDULER_IMPL_H_