Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 28123002: Introduce a separate gyp file for content shell and tests (Closed)

Created:
7 years, 2 months ago by jochen (gone - plz use gerrit)
Modified:
7 years, 2 months ago
CC:
chromium-reviews, sadrul, tfarina, amit, jam, joi+watch-content_chromium.org, grt+watch_chromium.org, darin-cc_chromium.org, robertshield, chromium-apps-reviews_chromium.org, kalyank, android-webview-reviews_chromium.org, ben+ash_chromium.org
Visibility:
Public.

Description

Introduce a separate gyp file for content shell and tests This will make it possible to depend on components from content shell BUG=247431 R=jam@chromium.org TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=229620

Patch Set 1 #

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -433 lines) Patch
M android_webview/android_webview_tests.gypi View 3 chunks +3 lines, -3 lines 0 comments Download
M apps/apps.gypi View 1 chunk +1 line, -1 line 0 comments Download
M ash/ash.gyp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M build/all.gyp View 13 chunks +24 lines, -24 lines 0 comments Download
M build/all_android.gyp View 4 chunks +10 lines, -10 lines 0 comments Download
M chrome/chrome.gyp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/chrome_frame.gyp View 1 chunk +1 line, -1 line 0 comments Download
M components/components_tests.gypi View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/content.gyp View 1 1 chunk +0 lines, -4 lines 0 comments Download
M content/content_shell.gypi View 4 chunks +11 lines, -13 lines 0 comments Download
M content/content_shell_and_tests.gyp View 1 1 chunk +6 lines, -325 lines 0 comments Download
M content/content_tests.gypi View 1 16 chunks +45 lines, -35 lines 0 comments Download
M ui/views/views.gyp View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jochen (gone - plz use gerrit)
plz review
7 years, 2 months ago (2013-10-18 03:16:27 UTC) #1
mnaganov (inactive)
On 2013/10/18 03:16:27, jochen wrote: > plz review Looks like my summer CL https://codereview.chromium.org/17366006/ resurrected. ...
7 years, 2 months ago (2013-10-18 08:31:17 UTC) #2
jam
lgtm
7 years, 2 months ago (2013-10-18 17:47:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/28123002/90001
7 years, 2 months ago (2013-10-19 21:14:12 UTC) #4
jochen (gone - plz use gerrit)
tbr'ing ben for updating dependencies on content gyp files all over the place
7 years, 2 months ago (2013-10-19 21:23:22 UTC) #5
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=31443
7 years, 2 months ago (2013-10-19 21:30:42 UTC) #6
jochen (gone - plz use gerrit)
7 years, 2 months ago (2013-10-19 22:13:22 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 manually as r229620 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698