Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: chrome/service/service_utility_process_host.h

Issue 2812263002: clean up printing::Image and printing::Metafile (Closed)
Patch Set: return Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/service/service_utility_process_host.h
diff --git a/chrome/service/service_utility_process_host.h b/chrome/service/service_utility_process_host.h
index 7b13f105105f73cced8e6cf8480c367d56d628fe..87b737d76fd3a7dd8a77eb18da677b3e26eb5f35 100644
--- a/chrome/service/service_utility_process_host.h
+++ b/chrome/service/service_utility_process_host.h
@@ -27,7 +27,6 @@ class ChildProcessHost;
}
namespace printing {
-class MetafilePlayer;
struct PdfRenderSettings;
struct PrinterCapsAndDefaults;
struct PrinterSemanticCapsAndDefaults;
@@ -48,9 +47,10 @@ class ServiceUtilityProcessHost : public content::ChildProcessHostDelegate {
// Called when the child process died before a reply was receieved.
virtual void OnChildDied() {}
- virtual void OnRenderPDFPagesToMetafilePageDone(
- float scale_factor,
- const printing::MetafilePlayer& emf) {}
+ virtual bool OnRenderPDFPagesToMetafilePageDone(std::vector<char>& emf_data,
Lei Zhang 2017/04/12 19:33:33 Why is |emf_data| non-const?
hal.canary 2017/04/13 20:55:38 oversight on my part.
+ float scale_factor) {
+ return false;
Lei Zhang 2017/04/12 19:33:33 The impl in the header is causing win_clang bot to
hal.canary 2017/04/13 20:55:38 Done.
+ }
// Called when at all pages in the PDF has been rendered.
virtual void OnRenderPDFPagesToMetafileDone(bool success) {}

Powered by Google App Engine
This is Rietveld 408576698