clean up printing::Image and printing::Metafile

printing/image.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef PRINTING_IMAGE_H_
 #define PRINTING_IMAGE_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <string>
 #include <vector>
 
 #include "base/logging.h"
 #include "printing/printing_export.h"
 #include "ui/gfx/geometry/size.h"
 
 namespace base {
 class FilePath;
 }
 
 namespace printing {
 
-class Metafile;
-
 // Lightweight raw-bitmap management. The image, once initialized, is immutable.
 // The main purpose is testing image contents.
 class PRINTING_EXPORT Image {
  public:
   // Creates the image from the metafile.  Deduces bounds based on bounds in
   // metafile.  If loading fails size().IsEmpty() will be true.
-  explicit Image(const Metafile& metafile);
+  Image(const void* metafile_src_buffer, size_t metafile_src_buffer_size);
 
   // Copy constructor.
   explicit Image(const Image& image);
 
   ~Image();
 
   const gfx::Size& size() const {
     return size_;
   }
 
@@ skipping 16 matching lines @@
 
   uint32_t pixel_at(int x, int y) const {
     DCHECK(x >= 0 && x < size_.width());
     DCHECK(y >= 0 && y < size_.height());
     const uint32_t* data = reinterpret_cast<const uint32_t*>(&*data_.begin());
     const uint32_t* data_row = data + y * row_length_ / sizeof(uint32_t);
     return Color(data_row[x]);
   }
 
  private:
-  // Construct from metafile.  This is kept internal since it's ambiguous what
-  // kind of data is used (png, bmp, metafile etc).
-  Image(const void* data, size_t size);
-
   bool LoadPng(const std::string& compressed);

[Lei Zhang, 2017/04/12 19:33:33]

This is dead code, BTW.

[hal.canary, 2017/04/13 20:55:38]

I'll clean up some of this dead code....and I just refactored PdfMetafileCg
again!  

[Lei Zhang, 2017/04/13 21:21:20]

There's certainly a lot of cruft here.

 
-  bool LoadMetafile(const Metafile& metafile);
+  bool LoadMetafile(const void* metafile_src_buffer,
+                    size_t metafile_src_buffer_size);
 
   // Pixel dimensions of the image.
   gfx::Size size_;
 
   // Length of a line in bytes.
   int row_length_;
 
   // Actual bitmap data in arrays of RGBAs (so when loaded as uint32_t, it's
   // 0xABGR).
   std::vector<unsigned char> data_;
 
   // Flag to signal if the comparison functions should ignore the alpha channel.
   const bool ignore_alpha_;  // Currently always true.
 
   // Prevent operator= (this function has no implementation)
   Image& operator=(const Image& image);
 };
 
 }  // namespace printing
 
 #endif  // PRINTING_IMAGE_H_