Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Side by Side Diff: services/device/device_service_test_base.h

Issue 2812223006: Replace device_sensor browsertest by service unittest. (Closed)
Patch Set: Replace device_sensor browsertest by service unittest. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef SERVICES_DEVICE_DEVICE_SERVICE_TEST_BASE_H_ 5 #ifndef SERVICES_DEVICE_DEVICE_SERVICE_TEST_BASE_H_
6 #define SERVICES_DEVICE_DEVICE_SERVICE_TEST_BASE_H_ 6 #define SERVICES_DEVICE_DEVICE_SERVICE_TEST_BASE_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "base/memory/ref_counted.h"
Reilly Grant (use Gerrit) 2017/04/18 19:36:18 This header is unused.
ke.he 2017/04/19 06:49:01 It should be moved into device_service_test_base.c
10 #include "base/threading/thread.h"
9 #include "services/service_manager/public/cpp/service_test.h" 11 #include "services/service_manager/public/cpp/service_test.h"
10 12
11 namespace device { 13 namespace device {
12 14
13 // Base class responsible to setup Device Service for test. 15 // Base class responsible to setup Device Service for test.
14 class DeviceServiceTestBase : public service_manager::test::ServiceTest { 16 class DeviceServiceTestBase : public service_manager::test::ServiceTest {
15 public: 17 public:
16 DeviceServiceTestBase(); 18 DeviceServiceTestBase();
17 ~DeviceServiceTestBase() override; 19 ~DeviceServiceTestBase() override;
18 20
19 private: 21 private:
20 // service_manager::test::ServiceTest: 22 // service_manager::test::ServiceTest:
21 std::unique_ptr<service_manager::Service> CreateService() override; 23 std::unique_ptr<service_manager::Service> CreateService() override;
22 24
25 base::Thread io_thread_;
26
23 DISALLOW_COPY_AND_ASSIGN(DeviceServiceTestBase); 27 DISALLOW_COPY_AND_ASSIGN(DeviceServiceTestBase);
24 }; 28 };
25 29
26 } // namespace device 30 } // namespace device
27 31
28 #endif // SERVICES_DEVICE_DEVICE_SERVICE_TEST_BASE_H_ 32 #endif // SERVICES_DEVICE_DEVICE_SERVICE_TEST_BASE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698