Replace device_sensor browsertest by service unittest.

services/device/device_service_test_base.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "services/device/device_service_test_base.h"
 
 #include <memory>
-
 #include "base/memory/ptr_util.h"
-#include "base/threading/thread.h"
 #include "mojo/public/cpp/bindings/binding_set.h"
 #include "services/device/device_service.h"
 #include "services/device/public/interfaces/constants.mojom.h"
 #include "services/service_manager/public/cpp/binder_registry.h"
 #include "services/service_manager/public/cpp/interface_factory.h"
 #include "services/service_manager/public/cpp/service_context.h"
 #include "services/service_manager/public/interfaces/service_factory.mojom.h"
 
 namespace device {
 
 namespace {
 
 const char kTestServiceName[] = "device_unittests";
 
 // The test service responsible to package Device Service.
 class ServiceTestClient : public service_manager::test::ServiceTestClient,
                           public service_manager::mojom::ServiceFactory,
                           public service_manager::InterfaceFactory<
                               service_manager::mojom::ServiceFactory> {
  public:
-  explicit ServiceTestClient(service_manager::test::ServiceTest* test)
+  explicit ServiceTestClient(
+      service_manager::test::ServiceTest* test,
+      scoped_refptr<base::SingleThreadTaskRunner> io_task_runner)
       : service_manager::test::ServiceTestClient(test),
-        io_thread_("DeviceServiceTestIOThread"),
-        file_thread_("DeviceServiceTestFileThread") {
+        file_thread_("DeviceServiceTestFileThread"),
+        io_task_runner_(std::move(io_task_runner)) {
     registry_.AddInterface<service_manager::mojom::ServiceFactory>(this);
   }
   ~ServiceTestClient() override {}
 
  protected:
   void OnBindInterface(const service_manager::ServiceInfo& source_info,
                        const std::string& interface_name,
                        mojo::ScopedMessagePipeHandle interface_pipe) override {
     registry_.BindInterface(source_info.identity, interface_name,
                             std::move(interface_pipe));
   }
 
   void CreateService(service_manager::mojom::ServiceRequest request,
                      const std::string& name) override {
     if (name == device::mojom::kServiceName) {
-      io_thread_.Start();
       file_thread_.Start();
 #if defined(OS_ANDROID)
       device_service_context_.reset(new service_manager::ServiceContext(
-          CreateDeviceService(file_thread_.task_runner(),
-                              io_thread_.task_runner(),
+          CreateDeviceService(file_thread_.task_runner(), io_task_runner_,
                               wake_lock_context_callback_),
           std::move(request)));
 #else
       device_service_context_.reset(new service_manager::ServiceContext(
-          CreateDeviceService(file_thread_.task_runner(),
-                              io_thread_.task_runner()),
+          CreateDeviceService(file_thread_.task_runner(), io_task_runner_),
           std::move(request)));
 #endif
     }
   }
 
   void Create(const service_manager::Identity& remote_identity,
               service_manager::mojom::ServiceFactoryRequest request) override {
     service_factory_bindings_.AddBinding(this, std::move(request));
   }
 
  private:
-  base::Thread io_thread_;
   base::Thread file_thread_;
   service_manager::BinderRegistry registry_;
   mojo::BindingSet<service_manager::mojom::ServiceFactory>
       service_factory_bindings_;
   std::unique_ptr<service_manager::ServiceContext> device_service_context_;
 
+  scoped_refptr<base::SingleThreadTaskRunner> io_task_runner_;
+
   WakeLockContextCallback wake_lock_context_callback_;
 };
 
 }  // namespace
 
 DeviceServiceTestBase::DeviceServiceTestBase()
-    : ServiceTest(kTestServiceName) {}
+    : ServiceTest(kTestServiceName), io_thread_("DeviceServiceTestIOThread") {}
 
 DeviceServiceTestBase::~DeviceServiceTestBase() {}
 
 std::unique_ptr<service_manager::Service>
 DeviceServiceTestBase::CreateService() {
-  return base::MakeUnique<ServiceTestClient>(this);
+  // Instead of start a new IO thread, we use main thread to simulate IO thread.
+  // The reason is: there are some sub services in device (DeviceSensorService
+  // for example) which are type of
+  // base::Singleton< ,base::LeakySingletonTraits<>>, this means the singleton
+  // instance can only be deleted when process exit. While all the service unit
+  // test cases run in same process, so the singleton service instance keeps
+  // alive across multiple unit test cases. There are some thread_checkers in
+  // the singleton instance, we have to make sure passing the same IO thread to
+  // each test case. So we decide to use main thread to simulate IO thread.

[Reilly Grant (use Gerrit), 2017/04/18 19:36:17]

// Instead of starting a new IO thread, we use the main thread to simulate 
// the IO thread. This is because there are some sub-services in device
// (DeviceSensorService, for example) which are of type
// base::Singleton<base::LeakySingletonTraits>, this means the singleton
// instance is never deleted. When all the service unit test cases run in
// same process the singleton service instance stays alive across multiple
// unit test cases. There are some thread_checkers in the singleton
// instance so we have to make sure passing the same IO thread to
// each test case. We use the main thread to provide this consistency.

[ke.he, 2017/04/19 06:49:01]

Done.

+
+  return base::MakeUnique<ServiceTestClient>(
+      this, base::ThreadTaskRunnerHandle::Get());
 }
 
 }  // namespace device