Move shared constants to //components/chrome_cleaner

components/chrome_cleaner/public/constants/constants.cc

Index: components/chrome_cleaner/public/constants/constants.cc
diff --git a/components/chrome_cleaner/public/constants/constants.cc b/components/chrome_cleaner/public/constants/constants.cc
new file mode 100644
index 0000000000000000000000000000000000000000..616ca118dae9603dc373472cbed23c5c849474a0
--- /dev/null
+++ b/components/chrome_cleaner/public/constants/constants.cc
@@ -0,0 +1,50 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/chrome_cleaner/public/constants/constants.h"
+
+namespace chrome_cleaner {
+
+// Command line switches.
+const char kChromeChannelSwitch[] = "chrome-channel";
+
+const char kChromeExePathSwitch[] = "chrome-exe-path";
+
+const char kChromeMojoPipeTokenSwitch[] = "chrome-mojo-pipe-token";
+
+const char kChromePromptSwitch[] = "chrome-prompt";
+
+const char kChromeSystemInstallSwitch[] = "chrome-system-install";
+
+const char kChromeVersionSwitch[] = "chrome-version";
+
+const char kEnableCrashReporting[] = "enable-crash-reporting";
+
+const char kExtendedSafeBrowsingEnabledSwitch[] =
+    "extended-safebrowsing-enabled";
+
+const char kSessionIdSwitch[] = "session-id";
+
+const char kUmaUserSwitch[] = "uma-user";
+
+// Registry paths.
+const wchar_t kSoftwareRemovalToolRegistryKey[] =
+    L"Software\\Google\\Software Removal Tool";
+
+const wchar_t kCleanerSuffixRegistryKey[] = L"Cleaner";
+
+const wchar_t kEndTimeValueName[] = L"EndTime";
+const wchar_t kStartTimeValueName[] = L"StartTime";

[Joe Mason, 2017/04/13 17:54:01]

Nit: either put a blank line between all of these, or none of them. (I would
prefer this whole file have no blank lines between constants, just a blank
between the switches and paths and one between the paths and the values.

Also please sort these the same way they're sorted in the header file.

[ftirelo, 2017/04/18 15:26:49]

Done.

+
+const wchar_t kExitCodeValueName[] = L"ExitCode";
+const wchar_t kUploadResultsValueName[] = L"UploadResults";
+const wchar_t kVersionValueName[] = L"Version";
+
+const wchar_t kScanTimesSubKey[] = L"ScanTimes";
+const wchar_t kFoundUwsValueName[] = L"FoundUws";

[Joe Mason, 2017/04/13 17:54:01]

Nit: please add a comment saying that the lower-case s can't be changed for
compatibility with older versions, so that people looking at this code in the
future don't "fix" it.

[ftirelo, 2017/04/18 15:26:49]

Done.

+const wchar_t kMemoryUsedValueName[] = L"MemoryUsed";
+const wchar_t kLogsUploadResultValueName[] = L"LogsUploadResult";
+const wchar_t kEngineErrorCodeValueName[] = L"EngineErrorCode";
+
+}  // namespace chrome_cleaner