chrome/browser/extensions/api/content_settings/content_settings_store.cc - Issue 2812113004: Write last_modified date to Content Settings in the PrefProvider

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/content_settings/content_settings_store.cc

Issue 2812113004: Write last_modified date to Content Settings in the PrefProvider (Closed)

Patch Set: fix comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/content_settings/content_settings_pref_provider_unittest.cc ('K') | « chrome/browser/content_settings/host_content_settings_map_unittest.cc ('k') | chrome/browser/permissions/permission_decision_auto_blocker_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/content_settings/content_settings_store.cc

diff --git a/chrome/browser/extensions/api/content_settings/content_settings_store.cc b/chrome/browser/extensions/api/content_settings/content_settings_store.cc

index 6f2a5797051cf8651c9e0d1898dc991f85ea9dff..aeab4cc6bb5249723cef94a387390bf1ff84487c 100644

--- a/chrome/browser/extensions/api/content_settings/content_settings_store.cc

+++ b/chrome/browser/extensions/api/content_settings/content_settings_store.cc

@@ -109,8 +109,9 @@ void ContentSettingsStore::SetExtensionContentSetting(

if (setting == CONTENT_SETTING_DEFAULT) {

map->DeleteValue(primary_pattern, secondary_pattern, type, identifier);

} else {

+ // Do not set a timestamp for extension settings.

map->SetValue(primary_pattern, secondary_pattern, type, identifier,

- new base::Value(setting));

+ base::Time(), new base::Value(setting));

}