Write last_modified date to Content Settings in the PrefProvider

components/content_settings/core/browser/content_settings_pref_provider.h

Index: components/content_settings/core/browser/content_settings_pref_provider.h
diff --git a/components/content_settings/core/browser/content_settings_pref_provider.h b/components/content_settings/core/browser/content_settings_pref_provider.h
index 9f33e158f6e21b8ffafa08e48319ced333261fa0..6f6c80cb246e61ed9edac526d5bca5278f1e7802 100644
--- a/components/content_settings/core/browser/content_settings_pref_provider.h
+++ b/components/content_settings/core/browser/content_settings_pref_provider.h
@@ -32,7 +32,7 @@ class PrefProvider : public ObservableProvider {
  public:
   static void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry);
 
-  PrefProvider(PrefService* prefs, bool incognito);
+  PrefProvider(PrefService* prefs, bool incognito, bool store_last_modified);
   ~PrefProvider() override;
 
   // ProviderInterface implementations.
@@ -47,6 +47,13 @@ class PrefProvider : public ObservableProvider {
                          const ResourceIdentifier& resource_identifier,
                          base::Value* value) override;
 
+  // Delete a setting if its |last_modified| date is greater or equal to
+  // |begin_time|.
+  void DeleteWebsiteSetting(const ContentSettingsPattern& primary_pattern,
+                            const ContentSettingsPattern& secondary_pattern,
+                            ContentSettingsType content_type,
+                            base::Time begin_time);

[raymes, 2017/04/24 03:20:23]

const base::Time&

[raymes, 2017/04/24 03:20:23]

Should we add a unittest for this?

[dullweber, 2017/04/25 10:50:44]

I already added a PrefProviderTest.DeleteWebsiteSetting test that covers this
method. Is that enough? The ContentSettingsPref is currently not tested
separately from the PrefProvider.

[raymes, 2017/04/26 01:54:17]

Ah sorry - I missed that :) 

+
   void ClearAllContentSettingsRules(ContentSettingsType content_type) override;
 
   void ShutdownOnUIThread() override;