Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(790)

Issue 2812093002: Simplify PackageMapUriResolver - one folder, return any file, or null. (Closed)

Created:
3 years, 8 months ago by scheglov
Modified:
3 years, 8 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Simplify PackageMapUriResolver - one folder, return any file, or null. If the package is know, we return the corresponding file, whether it exists or not. If the package is not know, there is no valid Source to resolve to, so we return null. We don't need all the features that existed. Internally we switched to BazelPackageUriResolver, which has its own logica for searching files in workspaces across multiple folders. All the places where we create PackageMapUriResolver in analyzer or analysis_server, we create it with exactly one folder. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/6fe8e2278b2cb678ad016b6151c12d016bc7a7db

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -141 lines) Patch
M pkg/analysis_server/test/context_manager_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analyzer/lib/source/package_map_resolver.dart View 2 chunks +20 lines, -56 lines 0 comments Download
M pkg/analyzer/test/source/package_map_resolver_test.dart View 3 chunks +8 lines, -83 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 8 months ago (2017-04-11 19:56:08 UTC) #1
Brian Wilkerson
lgtm
3 years, 8 months ago (2017-04-11 20:00:13 UTC) #2
scheglov
3 years, 8 months ago (2017-04-11 20:04:04 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6fe8e2278b2cb678ad016b6151c12d016bc7a7db (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698