Issue 2812056: Relanding http://codereview.chromium.org/2870050/show.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2812056: Relanding http://codereview.chromium.org/2870050/show. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 10 months ago by tfarina

Modified:
4 years ago

Reviewers:
tyoshino

CC:
chromium-reviews, ben+cc_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
git://git.chromium.org/chromium.git

Visibility:
Public.

Description

Relanding http://codereview.chromium.org/2870050/show. It was needed to revert the first one because of a bad git merge. Now it should be safe. TBR=brettw BUG=None TEST=trybots Signed-off-by: Thiago Farina <tfarina@chromium.org>; Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52752

Patch Set 1 : #

Patch Set 2 : rebased #

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -36 lines)			Patch
M	chrome/browser/renderer_host/render_view_host.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/renderer_host/render_view_host.cc	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	chrome/browser/renderer_host/render_view_host_delegate.h	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/renderer_host/render_view_host_delegate.cc	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/renderer_host/render_widget_host.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/renderer_host/render_widget_host_view_gtk.cc	View		1 chunk	+1 line, -5 lines	0 comments	Download
M	chrome/browser/renderer_host/render_widget_host_view_win.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/tab_contents/tab_contents.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/tab_contents/tab_contents.cc	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/tab_contents/tab_contents_delegate.h	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/tab_contents/tab_contents_delegate.cc	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Trybot results: mac linux win

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

tyoshino

On 2010/07/16 03:44:47, tfarina wrote: > Not familiar with the change, but the change you ...

4 years, 10 months ago (2010-07-16 03:56:35 UTC) #2

tfarina

4 years, 10 months ago (2010-07-16 14:53:16 UTC) #3

On 2010/07/16 03:56:35, tyoshino wrote:
> On 2010/07/16 03:44:47, tfarina wrote:
> > 
> 
> Not familiar with the change, but the change you made from the original CL
looks
> good to me (CanBlur is removed from tab_contents_delegate.cc)
> 
> Please make sure the failure on try bots are not problem.

I think now it will be fine, linux passed, mac is still running but is going to
be fine too, remaining win solo.
Please, may you have another look?

Expand Messages | Collapse Messages