Issue 2812037: Adding FAILS_ for failing worker tests

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2812037: Adding FAILS_ for failing worker tests (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 11 months ago by kinuko

Modified:
4 years ago

Reviewers:
Andrew T Wilson

CC:
chromium-reviews, jam, Paweł Hajdan Jr.

Visibility:
Public.

Description

Adding FAILS_ for failing worker tests BUG=48082 TBR=yurys Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51378

Patch Set 1 #

Patch Set 2 : remove WorkerMessagePort #

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome/worker/worker_uitest.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download

Trybot results:

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Andrew T Wilson

It looks like the webkit roll causing this was rolled back. Can you roll this ...

4 years, 11 months ago (2010-07-01 18:45:26 UTC) #1

kinuko

4 years, 11 months ago (2010-07-01 19:13:38 UTC) #2

Yep, it was reverted after the rollback.  Thanks for the headsup.

http://codereview.chromium.org/2878019

On Thu, Jul 1, 2010 at 11:45 AM, <atwilson@chromium.org> wrote:

> It looks like the webkit roll causing this was rolled back. Can you roll
> this
> back also?
>
> http://codereview.chromium.org/2812037/show
>

Expand Messages | Collapse Messages