Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 281203002: PPAPI: Make generator support "no_interface_string" (Closed)

Created:
6 years, 7 months ago by dmichael (off chromium)
Modified:
6 years, 7 months ago
Reviewers:
teravest
CC:
chromium-reviews
Visibility:
Public.

Description

PPAPI: Make generator support "no_interface_string" This is so I can introduce a new way to do PPP interfaces that are passed to a related PPB interface, instead of using PPP_GetInterface. Note this doesn't add support for the PNaCl shim yet, although it should at least make it compile. BUG=367896 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271425

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
M ppapi/generators/idl_c_header.py View 1 chunk +3 lines, -0 lines 0 comments Download
M ppapi/generators/idl_gen_wrapper.py View 1 chunk +3 lines, -1 line 0 comments Download
M ppapi/generators/test_cgen/interface.h View 1 chunk +6 lines, -0 lines 0 comments Download
M ppapi/generators/test_cgen/interface.idl View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
dmichael (off chromium)
6 years, 7 months ago (2014-05-14 18:02:29 UTC) #1
teravest
lgtm
6 years, 7 months ago (2014-05-14 18:04:36 UTC) #2
dmichael (off chromium)
The CQ bit was checked by dmichael@chromium.org
6 years, 7 months ago (2014-05-14 18:05:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/281203002/1
6 years, 7 months ago (2014-05-14 18:05:14 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-14 21:24:46 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-14 21:40:10 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/builds/31526)
6 years, 7 months ago (2014-05-14 21:40:10 UTC) #7
dmichael (off chromium)
The CQ bit was checked by dmichael@chromium.org
6 years, 7 months ago (2014-05-14 22:05:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/281203002/1
6 years, 7 months ago (2014-05-14 22:06:31 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-14 22:26:37 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-14 22:42:09 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/builds/31597)
6 years, 7 months ago (2014-05-14 22:42:10 UTC) #12
dmichael (off chromium)
The CQ bit was checked by dmichael@chromium.org
6 years, 7 months ago (2014-05-19 17:11:58 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/281203002/1
6 years, 7 months ago (2014-05-19 17:12:28 UTC) #14
commit-bot: I haz the power
6 years, 7 months ago (2014-05-19 18:16:13 UTC) #15
Message was sent while issue was closed.
Change committed as 271425

Powered by Google App Engine
This is Rietveld 408576698