Chromium Code Reviews| Index: chrome/browser/chromeos/login/saml/saml_browsertest.cc |
| diff --git a/chrome/browser/chromeos/login/saml/saml_browsertest.cc b/chrome/browser/chromeos/login/saml/saml_browsertest.cc |
| index b46f31a64a9a3e9aed7ef3710526b7831ad7794c..cbd07bb3aa172e3f0773392865879b65b32155fa 100644 |
| --- a/chrome/browser/chromeos/login/saml/saml_browsertest.cc |
| +++ b/chrome/browser/chromeos/login/saml/saml_browsertest.cc |
| @@ -1346,9 +1346,17 @@ IN_PROC_BROWSER_TEST_F(SAMLPolicyTest, TransferCookiesAffiliated) { |
| EXPECT_EQ(kSAMLIdPCookieValue2, GetCookieValue(kSAMLIdPCookieName)); |
| } |
| -// Flaky on Debug, ASan and MSan bots: crbug.com/683161. |
| -IN_PROC_BROWSER_TEST_F(SAMLPolicyTest, |
| - DISABLED_PRE_TransferCookiesUnaffiliated) { |
| +// PRE_TransferCookiesUnaffiliated and TransferCookiesUnaffiliated are flaky on |
| +// MSAN and ASAN, most probably timing out. See crbug.com/683161. |
| +#if defined(MEMORY_SANITIZER) || defined(ADDRESS_SANITIZER) |
| +#define MAYBE_PRE_TransferCookiesUnaffiliated \ |
| + DISABLED_PRE_TransferCookiesUnaffiliated |
| +#define MAYBE_TransferCookiesUnaffiliated DISABLED_TransferCookiesUnaffiliated |
| +#else |
| +#define MAYBE_PRE_TransferCookiesUnaffiliated PRE_TransferCookiesUnaffiliated |
| +#define MAYBE_TransferCookiesUnaffiliated TransferCookiesUnaffiliated |
| +#endif |
|
achuithb
2017/04/11 18:52:14
maybe a newline after this line?
emaxx
2017/04/11 23:16:40
Done.
|
| +IN_PROC_BROWSER_TEST_F(SAMLPolicyTest, MAYBE_PRE_TransferCookiesUnaffiliated) { |
| fake_saml_idp()->SetCookieValue(kSAMLIdPCookieValue1); |
| LogInWithSAML(kDifferentDomainSAMLUserEmail, |
| kTestAuthSIDCookie1, |
| @@ -1364,8 +1372,7 @@ IN_PROC_BROWSER_TEST_F(SAMLPolicyTest, |
| // IdP are not transferred to a user's profile on subsequent login if the user |
| // does not belong to the domain that the device is enrolled into. Also verifies |
| // that GAIA cookies are not transferred. |
| -// Flaky on Debug, ASan and MSan bots: crbug.com/683161. |
| -IN_PROC_BROWSER_TEST_F(SAMLPolicyTest, DISABLED_TransferCookiesUnaffiliated) { |
| +IN_PROC_BROWSER_TEST_F(SAMLPolicyTest, MAYBE_TransferCookiesUnaffiliated) { |
| fake_saml_idp()->SetCookieValue(kSAMLIdPCookieValue2); |
| fake_saml_idp()->SetLoginHTMLTemplate("saml_login.html"); |
| ShowGAIALoginForm(); |