Issue 2812007: Remove compact navbar: 1st step.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2812007: Remove compact navbar: 1st step. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 11 months ago by oshima

Modified:
3 years, 11 months ago

Reviewers:
sky

CC:
chromium-reviews, davemoore+watch_chromium.org, ben+cc_chromium.org, Paweł Hajdan Jr.

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

Remove compact navbar: 1st step. Remove menu, accelerator and tests. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50135

Patch Set 1 #

Patch Set 2 : " #

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -174 lines)			Patch
D	chrome/browser/chromeos/compact_location_bar_host_browsertest.cc	View	1 chunk	+0 lines, -98 lines	0 comments	Download
D	chrome/browser/chromeos/compact_navigation_bar_browsertest.cc	View	1 chunk	+0 lines, -67 lines	0 comments	Download
M	chrome/browser/chromeos/status/browser_status_area_view.cc	View	3 chunks	+1 line, -6 lines	0 comments	Download
M	chrome/browser/views/accelerator_table_gtk.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Trybot results: linux_view linux_chromeos linux win mac

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

oshima

4 years, 11 months ago (2010-06-17 18:34:21 UTC) #3

On 2010/06/17 15:56:25, sky wrote:
> OK, but Nicholas is now super grumpy.

I'll wait full removal for a while in case we want to salvage this feature.
(this Cl should be easy to revert)

Expand Messages | Collapse Messages