Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Side by Side Diff: chrome/browser/chromeos/status/browser_status_area_view.cc

Issue 2812007: Remove compact navbar: 1st step. (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: " Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/status/browser_status_area_view.h" 5 #include "chrome/browser/chromeos/status/browser_status_area_view.h"
6 6
7 #include "app/l10n_util.h" 7 #include "app/l10n_util.h"
8 #include "app/theme_provider.h" 8 #include "app/theme_provider.h"
9 #include "base/string_util.h" 9 #include "base/string_util.h"
10 #include "chrome/app/chrome_dll_resource.h" 10 #include "chrome/app/chrome_dll_resource.h"
(...skipping 25 matching lines...) Expand all
36 // so we just pick up the numbering where that stops. 36 // so we just pick up the numbering where that stops.
37 enum OtherCommands { 37 enum OtherCommands {
38 CREATE_NEW_WINDOW = StatusAreaView::OPEN_TABS_ON_RIGHT + 1, 38 CREATE_NEW_WINDOW = StatusAreaView::OPEN_TABS_ON_RIGHT + 1,
39 }; 39 };
40 40
41 explicit OptionsMenuModel(BrowserView* browser_view) 41 explicit OptionsMenuModel(BrowserView* browser_view)
42 : SimpleMenuModel(this), 42 : SimpleMenuModel(this),
43 browser_view_(browser_view) { 43 browser_view_(browser_view) {
44 AddCheckItemWithStringId(IDC_TOGGLE_VERTICAL_TABS, 44 AddCheckItemWithStringId(IDC_TOGGLE_VERTICAL_TABS,
45 IDS_TAB_CXMENU_USE_VERTICAL_TABS); 45 IDS_TAB_CXMENU_USE_VERTICAL_TABS);
46 AddCheckItemWithStringId(IDC_COMPACT_NAVBAR, IDS_COMPACT_NAVBAR);
47 AddSeparator(); 46 AddSeparator();
48 47
49 AddCheckItem(static_cast<int>(StatusAreaView::OPEN_TABS_ON_LEFT), 48 AddCheckItem(static_cast<int>(StatusAreaView::OPEN_TABS_ON_LEFT),
50 ASCIIToUTF16("Open tabs on left")); 49 ASCIIToUTF16("Open tabs on left"));
51 AddCheckItem(static_cast<int>(StatusAreaView::OPEN_TABS_CLOBBER), 50 AddCheckItem(static_cast<int>(StatusAreaView::OPEN_TABS_CLOBBER),
52 ASCIIToUTF16("Open tabs clobber")); 51 ASCIIToUTF16("Open tabs clobber"));
53 AddCheckItem(static_cast<int>(StatusAreaView::OPEN_TABS_ON_RIGHT), 52 AddCheckItem(static_cast<int>(StatusAreaView::OPEN_TABS_ON_RIGHT),
54 ASCIIToUTF16("Open tabs on right")); 53 ASCIIToUTF16("Open tabs on right"));
55 } 54 }
56 virtual ~OptionsMenuModel() { 55 virtual ~OptionsMenuModel() {
57 } 56 }
58 57
59 // SimpleMenuModel::Delegate implementation. 58 // SimpleMenuModel::Delegate implementation.
60 virtual bool IsCommandIdChecked(int command_id) const { 59 virtual bool IsCommandIdChecked(int command_id) const {
61 if (command_id == IDC_TOGGLE_VERTICAL_TABS) 60 if (command_id == IDC_TOGGLE_VERTICAL_TABS)
62 return browser_view_->UseVerticalTabs(); 61 return browser_view_->UseVerticalTabs();
63 if (command_id == IDC_COMPACT_NAVBAR)
64 return browser_view_->is_compact_style();
65 return StatusAreaView::GetOpenTabsMode() == command_id; 62 return StatusAreaView::GetOpenTabsMode() == command_id;
66 } 63 }
67 virtual bool IsCommandIdEnabled(int command_id) const { 64 virtual bool IsCommandIdEnabled(int command_id) const {
68 return true; 65 return true;
69 } 66 }
70 virtual bool GetAcceleratorForCommandId( 67 virtual bool GetAcceleratorForCommandId(
71 int command_id, 68 int command_id,
72 menus::Accelerator* accelerator) { 69 menus::Accelerator* accelerator) {
73 return command_id == IDC_COMPACT_NAVBAR ? 70 return false;
74 browser_view_->GetAccelerator(command_id, accelerator) : false;
75 } 71 }
76 virtual void ExecuteCommand(int command_id) { 72 virtual void ExecuteCommand(int command_id) {
77 switch (command_id) { 73 switch (command_id) {
78 case IDC_TOGGLE_VERTICAL_TABS: 74 case IDC_TOGGLE_VERTICAL_TABS:
79 case IDC_COMPACT_NAVBAR:
80 browser_view_->browser()->ExecuteCommand(command_id); 75 browser_view_->browser()->ExecuteCommand(command_id);
81 break; 76 break;
82 case StatusAreaView::OPEN_TABS_ON_LEFT: 77 case StatusAreaView::OPEN_TABS_ON_LEFT:
83 case StatusAreaView::OPEN_TABS_CLOBBER: 78 case StatusAreaView::OPEN_TABS_CLOBBER:
84 case StatusAreaView::OPEN_TABS_ON_RIGHT: 79 case StatusAreaView::OPEN_TABS_ON_RIGHT:
85 StatusAreaView::SetOpenTabsMode( 80 StatusAreaView::SetOpenTabsMode(
86 static_cast<StatusAreaView::OpenTabsMode>(command_id)); 81 static_cast<StatusAreaView::OpenTabsMode>(command_id));
87 break; 82 break;
88 default: 83 default:
89 NOTREACHED(); 84 NOTREACHED();
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
167 162
168 void BrowserStatusAreaView::ExecuteCommand(int command_id) { 163 void BrowserStatusAreaView::ExecuteCommand(int command_id) {
169 browser_view_->browser()->ExecuteCommand(command_id); 164 browser_view_->browser()->ExecuteCommand(command_id);
170 } 165 }
171 166
172 void BrowserStatusAreaView::RunMenu(views::View* source, const gfx::Point& pt) { 167 void BrowserStatusAreaView::RunMenu(views::View* source, const gfx::Point& pt) {
173 app_menu_menu_->RunMenuAt(pt, views::Menu2::ALIGN_TOPRIGHT); 168 app_menu_menu_->RunMenuAt(pt, views::Menu2::ALIGN_TOPRIGHT);
174 } 169 }
175 170
176 } // namespace chromeos 171 } // namespace chromeos
OLDNEW
« no previous file with comments | « chrome/browser/chromeos/compact_navigation_bar_browsertest.cc ('k') | chrome/browser/views/accelerator_table_gtk.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698