A treegrid should expose its rows in MSAA/IA2 as outlineitems.

content/browser/accessibility/browser_accessibility_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/accessibility/browser_accessibility_win.h"
 
 #include <UIAutomationClient.h>
 #include <UIAutomationCoreApi.h>
 
 #include <algorithm>
@@ skipping 5400 matching lines @@
       ia_role = ROLE_SYSTEM_GROUPING;
       break;
     case ui::AX_ROLE_REGION:
       if (html_tag == L"section") {
         ia_role = ROLE_SYSTEM_GROUPING;
         ia2_role = IA2_ROLE_SECTION;
       } else {
         ia_role = ROLE_SYSTEM_PANE;
       }
       break;
-    case ui::AX_ROLE_ROW:
-      ia_role = ROLE_SYSTEM_ROW;
+    case ui::AX_ROLE_ROW: {
+      // Role changes depending on whether row is inside a treegrid
+      // https://www.w3.org/TR/core-aam-1.1/#role-map-row
+      ia_role = IsInTreeGrid(this) ? ROLE_SYSTEM_OUTLINEITEM : ROLE_SYSTEM_ROW;
       break;
+    }
     case ui::AX_ROLE_ROW_HEADER:
       ia_role = ROLE_SYSTEM_ROWHEADER;
       break;
     case ui::AX_ROLE_RUBY:
       ia_role = ROLE_SYSTEM_TEXT;
       ia2_role = IA2_ROLE_TEXT_FRAME;
       break;
     case ui::AX_ROLE_RULER:
       ia_role = ROLE_SYSTEM_CLIENT;
       ia2_role = IA2_ROLE_RULER;
@@ skipping 155 matching lines @@
   if (!ia2_role)
     ia2_role = ia_role;
 
   win_attributes_->ia_role = ia_role;
   win_attributes_->ia_state = ia_state;
   win_attributes_->role_name = role_name;
   win_attributes_->ia2_role = ia2_role;
   win_attributes_->ia2_state = ia2_state;
 }
 
+bool BrowserAccessibilityWin::IsInTreeGrid(const BrowserAccessibility* item) {
+  BrowserAccessibility* container = item->PlatformGetParent();
+  if (container && container->GetRole() == ui::AX_ROLE_GROUP) {
+    // If parent was a rowgroup, we need to look at the grandparent
+    container = container->PlatformGetParent();
+  }
+
+  if (!container) {
+    return false;
+  }
+
+  const ui::AXRole role = container->GetRole();
+  return role == ui::AX_ROLE_TREE_GRID ||
+         (role == ui::AX_ROLE_TABLE &&

[dmazzoni, 2017/04/12 20:35:12]

Can you add a comment explaining why we'd have something
with a role of TABLE even though the ARIA role was "treegrid"?
Is it a bug or expected behavior?

Also, do we really want an OUTLINE_ITEM inside a role of TABLE?

[aleventhal, 2017/04/17 22:06:42]

I was following the code in InitRoleAndState() here:
https://cs.chromium.org/chromium/src/content/browser/accessibility/browser_ac...

When I just checked for AX_ROLE_TREE_GRID my new tests failed. I took the lines
above as an indication that it was the correct way to check for a treegrid. Is
it not?

+          container->GetString16Attribute(ui::AX_ATTR_ROLE) == L"treegrid");

[dmazzoni, 2017/04/12 20:35:12]

nit: call GetStringAttribute(ui::AX_ATTR_ROLE) == "treegrid" instead - when
you're just doing a string comparison, that will return an existing object
reference, while GetString16Attribute needs to convert.

[aleventhal, 2017/04/17 22:06:42]

Assuming we keep this code, should I change it in the other place referenced
above as well?

+}
+
 BrowserAccessibilityWin* ToBrowserAccessibilityWin(BrowserAccessibility* obj) {
   DCHECK(!obj || obj->IsNative());
   return static_cast<BrowserAccessibilityWin*>(obj);
 }
 
 const BrowserAccessibilityWin*
 ToBrowserAccessibilityWin(const BrowserAccessibility* obj) {
   DCHECK(!obj || obj->IsNative());
   return static_cast<const BrowserAccessibilityWin*>(obj);
 }
 
 }  // namespace content