Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4307)

Unified Diff: chrome/browser/resources/md_extensions/service.js

Issue 2811993004: [MD Extensions] Add support for URL navigation (Closed)
Patch Set: . Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/md_extensions/service.js
diff --git a/chrome/browser/resources/md_extensions/service.js b/chrome/browser/resources/md_extensions/service.js
index 3855db8ceaf5ece1d44ac92283e318d98b2cdfd2..1d19e2c189d411ae3171d80a0d14a983c3c5eb1c 100644
--- a/chrome/browser/resources/md_extensions/service.js
+++ b/chrome/browser/resources/md_extensions/service.js
@@ -50,14 +50,7 @@ cr.define('extensions', function() {
for (let extension of extensions)
this.manager_.addItem(extension);
- var id = new URLSearchParams(location.search).get('id');
- if (id) {
- var data = this.extensions_.find(function(e) {
- return e.id == id;
- });
- if (data)
- this.manager_.showItemDetails(data);
- }
+ this.manager_.initPage();
}.bind(this));
chrome.developerPrivate.getProfileConfiguration(
this.onProfileStateChanged_.bind(this));
@@ -257,14 +250,16 @@ cr.define('extensions', function() {
/** @override */
showItemOptionsPage: function(id) {
- var extension = this.extensions_.find(function(extension) {
- return extension.id == id;
+ var extension = this.extensions_.find(function(e) {
+ return e.id == id;
});
assert(extension && extension.optionsPage);
- if (extension.optionsPage.openInTab)
+ if (extension.optionsPage.openInTab) {
chrome.developerPrivate.showOptions(id);
- else
- this.manager_.optionsDialog.show(extension);
+ } else {
+ this.manager_.changePage(
+ {page: Page.DETAILS, subpage: Subpage.OPTIONS, id: id});
+ }
},
/** @override */

Powered by Google App Engine
This is Rietveld 408576698