Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issue 281193002: Fail pixel tests when reference images are missing from cloud storage. (Closed)

Created:
6 years, 7 months ago by Ken Russell (switch to Gerrit)
Modified:
6 years, 7 months ago
Reviewers:
Zhenyao Mo, bajones
CC:
chromium-reviews, piman+watch_chromium.org, jam, darin-cc_chromium.org, danakj
Visibility:
Public.

Description

Fail pixel tests when reference images are missing from cloud storage. Turn the exception into a test failure which can be suppressed via the test expectations. Verified locally with a run that triggered the exception. Confirmed the failures can be suppressed. BUG=349262 TEST=./content/test/gpu/run_gpu_test.py pixel --browser=release --build-revision 270401 --download-refimg-from-cloud-storage --refimg-cloud-storage-bucket chromium-gpu-archive/reference-images --os-type linux --test-machine-name [fake name] NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270498

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M content/test/gpu/gpu_tests/pixel.py View 2 chunks +15 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
Ken Russell (switch to Gerrit)
Brandon, Mo: please review. Dana: FYI.
6 years, 7 months ago (2014-05-14 17:48:45 UTC) #1
bajones
lgtm
6 years, 7 months ago (2014-05-14 18:36:20 UTC) #2
Ken Russell (switch to Gerrit)
The CQ bit was checked by kbr@chromium.org
6 years, 7 months ago (2014-05-14 18:36:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kbr@chromium.org/281193002/1
6 years, 7 months ago (2014-05-14 18:37:28 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-14 22:26:40 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-14 22:31:33 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/builds/152017)
6 years, 7 months ago (2014-05-14 22:31:33 UTC) #7
Ken Russell (switch to Gerrit)
These try job failures are unrelated to this CL. I'm marking it NOTRY=true in order ...
6 years, 7 months ago (2014-05-14 22:53:10 UTC) #8
Ken Russell (switch to Gerrit)
The CQ bit was checked by kbr@chromium.org
6 years, 7 months ago (2014-05-14 22:53:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kbr@chromium.org/281193002/1
6 years, 7 months ago (2014-05-14 22:54:11 UTC) #10
commit-bot: I haz the power
6 years, 7 months ago (2014-05-14 23:04:32 UTC) #11
Message was sent while issue was closed.
Change committed as 270498

Powered by Google App Engine
This is Rietveld 408576698