Pull code associated with a Media PermissionRequest out of MediaStreamDevicesController

chrome/browser/media/webrtc/media_stream_devices_controller.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_MEDIA_WEBRTC_MEDIA_STREAM_DEVICES_CONTROLLER_H_
 #define CHROME_BROWSER_MEDIA_WEBRTC_MEDIA_STREAM_DEVICES_CONTROLLER_H_
 
 #include <map>
 #include <string>
 
@@ skipping 15 matching lines @@
 }
 
 namespace policy {
 class MediaStreamDevicesControllerBrowserTest;
 }
 
 namespace test {
 class MediaStreamDevicesControllerTestApi;
 }
 
-namespace internal {
-// Delegate showing permission prompts.
-class PermissionPromptDelegate {
+class MediaStreamDevicesController {
  public:
-  virtual void ShowPrompt(
-      bool user_gesture,
-      content::WebContents* web_contents,
-      std::unique_ptr<MediaStreamDevicesController> controller) = 0;
-};
-}
+  // This class is only needed until we unify the codepaths for permission
+  // requests. It can be removed once crbug.com/606138 is fixed.
+  class Request : public PermissionRequest {
+   public:
+    using PromptAnsweredCallback =
+        base::Callback<void(ContentSetting, bool /* persist */)>;

[Nico, 2017/04/24 13:51:53]

nit: spell this like `/*persist=*/bool` -- clang-format knows about that
convention, and it makes it clear that `/*persist=*/false` at a call site means
"set persist to false" (`false /*persist*/` could also mean "false here means we
persist").

Better yet, use enums instead of bools.

[raymes, 2017/04/26 00:28:14]

Thanks I didn't know that. That was the convention that I had always known and
seen used in Chrome but I'll keep this in mind for the future.

 
-class MediaStreamDevicesController : public PermissionRequest {
- public:
+    Request(Profile* profile,
+            bool is_asking_for_audio,
+            bool is_asking_for_video,
+            const GURL& security_origin,
+            PromptAnsweredCallback prompt_answered_callback);
+
+    ~Request() override;
+
+    bool IsAskingForAudio() const;
+    bool IsAskingForVideo() const;
+    base::string16 GetMessageText() const;
+
+    // PermissionRequest:
+    IconId GetIconId() const override;
+    base::string16 GetMessageTextFragment() const override;
+    GURL GetOrigin() const override;
+    void PermissionGranted() override;
+    void PermissionDenied() override;
+    void Cancelled() override;
+    void RequestFinished() override;
+    PermissionRequestType GetPermissionRequestType() const override;
+    bool ShouldShowPersistenceToggle() const override;
+
+   private:
+    Profile* profile_;
+
+    bool is_asking_for_audio_;
+    bool is_asking_for_video_;
+
+    GURL security_origin_;
+
+    PromptAnsweredCallback prompt_answered_callback_;
+
+    // Whether the prompt has been answered.
+    bool responded_;
+
+    DISALLOW_COPY_AND_ASSIGN(Request);
+  };
+
+  // This class is only needed interally and for tests. It can be removed once
+  // crbug.com/606138 is fixed. Delegate for showing permission prompts. It's
+  // only public because subclassing from a friend class doesn't work in gcc
+  // (see https://codereview.chromium.org/2768923003).
+  class PermissionPromptDelegate {

[Nico, 2017/04/24 13:51:53]

std::unique_ptr<PermissionPromptDelegate> delegate_; below deletes this class
through the base pointer, so it must have a virtual dtor, else the dtor of
subclasses won't be called. (Subclasses don't have dtors from what I can tell,
but it's still a latent bug.)

[raymes, 2017/04/26 00:28:14]

Thanks for catching this. Fixed in: https://codereview.chromium.org/2836093006# 

+   public:
+    virtual void ShowPrompt(
+        bool user_gesture,
+        content::WebContents* web_contents,
+        std::unique_ptr<MediaStreamDevicesController::Request> request) = 0;
+  };
+
   static void RequestPermissions(
       const content::MediaStreamRequest& request,
       const content::MediaResponseCallback& callback);
 
   // Registers the prefs backing the audio and video policies.
   static void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry);
 
-  ~MediaStreamDevicesController() override;
+  ~MediaStreamDevicesController();
 
   bool IsAskingForAudio() const;
   bool IsAskingForVideo() const;
-  base::string16 GetMessageText() const;
+
+  // Called when a permission prompt has been answered, with the |response| and
+  // whether the choice should be persisted.
+  void PromptAnswered(ContentSetting response, bool persist);
 
 #if defined(OS_ANDROID)
   // Called when the Android OS-level prompt is answered.
   void AndroidOSPromptAnswered(bool allowed);
 #endif  // defined(OS_ANDROID)
 
-  bool ShouldShowPersistenceToggle() const override;
-
-  // PermissionRequest:
-  IconId GetIconId() const override;
-  base::string16 GetMessageTextFragment() const override;
-  GURL GetOrigin() const override;
-  void PermissionGranted() override;
-  void PermissionDenied() override;
-  void Cancelled() override;
-  void RequestFinished() override;
-  PermissionRequestType GetPermissionRequestType() const override;
-
  private:
   friend class MediaStreamDevicesControllerTest;
   friend class test::MediaStreamDevicesControllerTestApi;
   friend class policy::MediaStreamDevicesControllerBrowserTest;
 
   class PermissionPromptDelegateImpl;
 
   static void RequestPermissionsWithDelegate(
       const content::MediaStreamRequest& request,
       const content::MediaResponseCallback& callback,
-      internal::PermissionPromptDelegate* delegate);
+      PermissionPromptDelegate* delegate);
 
   MediaStreamDevicesController(content::WebContents* web_contents,
                                const content::MediaStreamRequest& request,
                                const content::MediaResponseCallback& callback);
 
   bool IsAllowedForAudio() const;
   bool IsAllowedForVideo() const;
 
   // Returns a list of devices available for the request for the given
   // audio/video permission settings.
@@ skipping 51 matching lines @@
   // was created.
   TabSpecificContentSettings* content_settings_;
 
   // The original request for access to devices.
   const content::MediaStreamRequest request_;
 
   // The callback that needs to be Run to notify WebRTC of whether access to
   // audio/video devices was granted or not.
   content::MediaResponseCallback callback_;
 
-  std::unique_ptr<internal::PermissionPromptDelegate> delegate_;
+  std::unique_ptr<PermissionPromptDelegate> delegate_;
 
   DISALLOW_COPY_AND_ASSIGN(MediaStreamDevicesController);
 };
 
 #endif  // CHROME_BROWSER_MEDIA_WEBRTC_MEDIA_STREAM_DEVICES_CONTROLLER_H_