Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2470)

Unified Diff: chrome/browser/plugins/flash_download_interception_unittest.cc

Issue 2811903002: [HBD] Tighten-up which adobe.com/go links are intercepted as Flash URLs (Closed)
Patch Set: fix Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/plugins/flash_download_interception.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/plugins/flash_download_interception_unittest.cc
diff --git a/chrome/browser/plugins/flash_download_interception_unittest.cc b/chrome/browser/plugins/flash_download_interception_unittest.cc
index 9e861fcf56590de8588e65b5775f4562bfec100e..bd12b0b11ef2d3bf1746aa543a181e1d7a324496 100644
--- a/chrome/browser/plugins/flash_download_interception_unittest.cc
+++ b/chrome/browser/plugins/flash_download_interception_unittest.cc
@@ -49,6 +49,8 @@ TEST_F(FlashDownloadInterceptionTest, DownloadUrlVariations) {
"http://get.adobe.com/flashplayer",
"http://macromedia.com/go/getflashplayer",
"http://adobe.com/go/getflashplayer",
+ "http://adobe.com/go/CA-H-GET-FLASH",
+ "http://adobe.com/go/DE_CH-H-M-A2",
"http://adobe.com/go/gntray_dl_getflashplayer_jp",
};
@@ -58,14 +60,18 @@ TEST_F(FlashDownloadInterceptionTest, DownloadUrlVariations) {
}
const char* flash_no_intercept_urls[] = {
- "https://www.example.com",
- "http://example.com/get.adobe.com/flashplayer",
+ "https://www.example.com", "http://example.com/get.adobe.com/flashplayer",
"http://ww.macromedia.com/go/getflashplayer",
"http://wwwxmacromedia.com/go/getflashplayer",
"http://www.adobe.com/software/flash/about/",
"http://www.adobe.com/products/flashplayer.html",
"http://www.adobe.com/products/flashruntimes.html",
"http://www.adobe.com/go/flash",
+ // Don't intercept URLs containing just "fp" without a matching prefix.
+ "http://www.adobe.com/go/non-matching-prefix-fp",
+ // Don't match text within the query or fragment.
+ "http://www.adobe.com/go/non-matching?foo=flashplayer",
+ "http://www.adobe.com/go/non-matching#!foo=flashplayer",
};
for (auto* url : flash_no_intercept_urls) {
« no previous file with comments | « chrome/browser/plugins/flash_download_interception.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698