Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 281183002: ash: Cleanup ash_strings target. (Closed)

Created:
6 years, 7 months ago by tfarina
Modified:
6 years, 7 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Visibility:
Public.

Description

ash: Cleanup ash_strings target. While I'm here make it more consistent with the other foo_strings.gyp we have in the tree. Some changes: 1) Make it use grit_target.gypi 2) Have a consistent and path oriented grit_out_dir. 3) Prefix the action name with generate_ 4) Remove direct_dependent_settings, since that is what grit_target.gypi is for. R=jamescook@chromium.org TBR=thestig@chromium.org # for trivial change in chrome/ Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270863

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -14 lines) Patch
M ash/ash_strings.gyp View 1 chunk +5 lines, -12 lines 0 comments Download
M chrome/tools/build/repack_locales.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tfarina
small cleanup. ptal.
6 years, 7 months ago (2014-05-14 17:42:29 UTC) #1
James Cook
LGTM
6 years, 7 months ago (2014-05-14 19:03:23 UTC) #2
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 7 months ago (2014-05-15 22:31:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/281183002/1
6 years, 7 months ago (2014-05-15 22:31:45 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-15 23:59:03 UTC) #5
Message was sent while issue was closed.
Change committed as 270863

Powered by Google App Engine
This is Rietveld 408576698