components/offline_pages/core/prefetch/prefetch_service_impl_unittest.cc - Issue 2811813002: [Offline Pages] Set up the initial prefetching service.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/offline_pages/core/prefetch/prefetch_service_impl_unittest.cc

Issue 2811813002: [Offline Pages] Set up the initial prefetching service. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "components/offline_pages/core/prefetch/prefetch_service_impl.h"

	6

	7 #include "testing/gtest/include/gtest/gtest.h"

	8 #include "url/gurl.h"

	9

	10 namespace offline_pages {

	11

	12 TEST(PrefetchServiceTest, ServiceDoesNotCrash) {

	13 PrefetchServiceImpl service;

	14

	15 service.OnNewURLSuggestions(std::vector<GURL>());

	16 service.RemoveAllUnprocessedURLSuggestions();
	carlosk 2017/04/11 17:31:36 Question: how come debug build tests don't crash h Question: how come debug build tests don't crash here because of the NOTIMPLEMENTED calls? dewittj 2017/04/11 21:25:49 NOTIMPLEMENTED does not crash, it just logs. NOTR Show quoted text On 2017/04/11 17:31:36, carlosk wrote: > Question: how come debug build tests don't crash here because of the > NOTIMPLEMENTED calls? NOTIMPLEMENTED does not crash, it just logs. NOTREACHED() crashes.
	17 }

	18

	19 } // namespace offline_pages

OLD	NEW