Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Unified Diff: components/offline_items_collection/core/android/java/src/org/chromium/components/offline_items_collection/bridges/OfflineItemVisualsBridge.java

Issue 2811803006: Add support for pulling icons for OfflineItems (Closed)
Patch Set: Cleaned up the CL Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_items_collection/core/android/java/src/org/chromium/components/offline_items_collection/bridges/OfflineItemVisualsBridge.java
diff --git a/components/offline_items_collection/core/android/java/src/org/chromium/components/offline_items_collection/bridges/OfflineItemVisualsBridge.java b/components/offline_items_collection/core/android/java/src/org/chromium/components/offline_items_collection/bridges/OfflineItemVisualsBridge.java
new file mode 100644
index 0000000000000000000000000000000000000000..534e5f39f8b9888810631e9ee6aab563edb8bf45
--- /dev/null
+++ b/components/offline_items_collection/core/android/java/src/org/chromium/components/offline_items_collection/bridges/OfflineItemVisualsBridge.java
@@ -0,0 +1,33 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+package org.chromium.components.offline_items_collection.bridges;
+
+import android.graphics.Bitmap;
+
+import org.chromium.base.annotations.CalledByNative;
+import org.chromium.base.annotations.JNINamespace;
+import org.chromium.components.offline_items_collection.OfflineItemVisuals;
+
+/**
+ * The Java counterpart to the C++ class OfflineItemVisualsBridge
+ * (components/offline_items_collection/core/android/offline_item_visuals_bridge.h). This class has
+ * no public members or methods and is meant as a private factory to build
+ * {@link OfflineItemVisuals} instances.
+ */
+@JNINamespace("offline_items_collection::android")
+public class OfflineItemVisualsBridge {
nyquist 2017/04/13 05:08:24 Nit: also add final modifier to class?
David Trainor- moved to gerrit 2017/04/13 07:20:23 Done.
+ private OfflineItemVisualsBridge() {}
+
+ /**
+ * This is a helper method to allow C++ to create an {@link OfflineItemVisuals} object.
+ * @return The newly created {@link OfflineItemVisuals} based on the input parameters.
+ */
+ @CalledByNative
+ private static OfflineItemVisuals createOfflineItemVisuals(Bitmap icon) {
+ OfflineItemVisuals visuals = new OfflineItemVisuals();
+ visuals.icon = icon;
+ return visuals;
+ }
+}

Powered by Google App Engine
This is Rietveld 408576698