components/offline_items_collection/core/offline_content_aggregator_unittest.cc - Issue 2811803006: Add support for pulling icons for OfflineItems

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_items_collection/core/offline_content_aggregator_unittest.cc

Issue 2811803006: Add support for pulling icons for OfflineItems (Closed)

Patch Set: More findbugs Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/offline_items_collection/core/offline_content_aggregator.cc ('k') | components/offline_items_collection/core/offline_content_provider.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/offline_items_collection/core/offline_content_aggregator_unittest.cc

diff --git a/components/offline_items_collection/core/offline_content_aggregator_unittest.cc b/components/offline_items_collection/core/offline_content_aggregator_unittest.cc

index 361934084453b308d79fab96a625c10af07bb0e1..45d77fd42e2bee695148351eed2f48199099bb26 100644

--- a/components/offline_items_collection/core/offline_content_aggregator_unittest.cc

+++ b/components/offline_items_collection/core/offline_content_aggregator_unittest.cc

@@ -299,6 +299,8 @@ TEST_F(OfflineContentAggregatorTest, ActionPropagatesToRightProvider) {

EXPECT_CALL(provider2, ResumeDownload(id2)).Times(1);

EXPECT_CALL(provider1, PauseDownload(id1)).Times(1);

EXPECT_CALL(provider2, PauseDownload(id2)).Times(1);

+ EXPECT_CALL(provider1, GetVisualsForItem(id1, _)).Times(1);

+ EXPECT_CALL(provider2, GetVisualsForItem(id2, _)).Times(1);

aggregator_.OpenItem(id1);

aggregator_.OpenItem(id2);

aggregator_.RemoveItem(id1);

@@ -309,6 +311,8 @@ TEST_F(OfflineContentAggregatorTest, ActionPropagatesToRightProvider) {

aggregator_.ResumeDownload(id2);

aggregator_.PauseDownload(id1);

aggregator_.PauseDownload(id2);

+ aggregator_.GetVisualsForItem(id1, OfflineContentProvider::VisualsCallback());

+ aggregator_.GetVisualsForItem(id2, OfflineContentProvider::VisualsCallback());

}

TEST_F(OfflineContentAggregatorTest, ActionPropagatesAfterInitialize) {