Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadNotificationServiceTest.java

Issue 2811803006: Add support for pulling icons for OfflineItems (Closed)
Patch Set: More findbugs Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadNotificationServiceTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadNotificationServiceTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadNotificationServiceTest.java
index 02b45c98ca970ad10f7c40c28f1b582f8c1f37f0..85650cb5387dcbf774f1f030338b62c0bb84445e 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadNotificationServiceTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadNotificationServiceTest.java
@@ -296,7 +296,7 @@ public class DownloadNotificationServiceTest extends
DownloadNotificationService service = bindNotificationService();
ContentId id3 = LegacyHelpers.buildLegacyContentId(false, UUID.randomUUID().toString());
- service.notifyDownloadProgress(id3, "test", 1, 100L, 1L, 1L, true, true, false);
+ service.notifyDownloadProgress(id3, "test", 1, 100L, 1L, 1L, true, true, false, null);
assertEquals(3, getService().getNotificationIds().size());
int lastNotificationId = getService().getLastAddedNotificationId();
Set<String> entries = DownloadManagerService.getStoredDownloadInfo(
@@ -305,13 +305,13 @@ public class DownloadNotificationServiceTest extends
ContentId id1 = LegacyHelpers.buildLegacyContentId(false, guid1);
service.notifyDownloadSuccessful(
- id1, "/path/to/success", "success", 100L, false, false, true);
+ id1, "/path/to/success", "success", 100L, false, false, true, null);
entries = DownloadManagerService.getStoredDownloadInfo(
sharedPrefs, DownloadSharedPreferenceHelper.KEY_PENDING_DOWNLOAD_NOTIFICATIONS);
assertEquals(2, entries.size());
ContentId id2 = LegacyHelpers.buildLegacyContentId(false, guid2);
- service.notifyDownloadFailed(id2, "failed");
+ service.notifyDownloadFailed(id2, "failed", null);
entries = DownloadManagerService.getStoredDownloadInfo(
sharedPrefs, DownloadSharedPreferenceHelper.KEY_PENDING_DOWNLOAD_NOTIFICATIONS);
assertEquals(1, entries.size());
@@ -322,7 +322,7 @@ public class DownloadNotificationServiceTest extends
ContentId id4 = LegacyHelpers.buildLegacyContentId(false, UUID.randomUUID().toString());
service.notifyDownloadSuccessful(
- id4, "/path/to/success", "success", 100L, false, false, true);
+ id4, "/path/to/success", "success", 100L, false, false, true, null);
assertEquals(3, getService().getNotificationIds().size());
int nextNotificationId = getService().getLastAddedNotificationId();
service.cancelNotification(nextNotificationId, id4);
@@ -341,7 +341,8 @@ public class DownloadNotificationServiceTest extends
startNotificationService();
DownloadNotificationService service = bindNotificationService();
ContentId id = LegacyHelpers.buildLegacyContentId(false, UUID.randomUUID().toString());
- service.notifyDownloadSuccessful(id, "/path/to/test", "test", 100L, false, false, true);
+ service.notifyDownloadSuccessful(
+ id, "/path/to/test", "test", 100L, false, false, true, null);
assertEquals(1, getService().getNotificationIds().size());
}

Powered by Google App Engine
This is Rietveld 408576698