Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/download/SystemDownloadNotifier.java

Issue 2811803006: Add support for pulling icons for OfflineItems (Closed)
Patch Set: More findbugs Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/download/SystemDownloadNotifier.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/download/SystemDownloadNotifier.java b/chrome/android/java/src/org/chromium/chrome/browser/download/SystemDownloadNotifier.java
index 8612e0f71f5febb7c6e1307dbe62790c787074b7..8e9751e3d50f119b75d5488fef8dcd7b9cbb20c3 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/download/SystemDownloadNotifier.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/download/SystemDownloadNotifier.java
@@ -271,25 +271,26 @@ public class SystemDownloadNotifier implements DownloadNotifier, Observer {
info.getPercentCompleted(), info.getBytesReceived(),
info.getTimeRemainingInMillis(), notificationInfo.startTime,
info.isOffTheRecord(), notificationInfo.canDownloadWhileMetered,
- info.getIsTransient());
+ info.getIsTransient(), info.getIcon());
break;
case DOWNLOAD_NOTIFICATION_TYPE_PAUSE:
mBoundService.notifyDownloadPaused(
- info.getContentId(), true, false, info.getIsTransient());
+ info.getContentId(), true, false, info.getIsTransient(), info.getIcon());
break;
case DOWNLOAD_NOTIFICATION_TYPE_INTERRUPT:
mBoundService.notifyDownloadPaused(info.getContentId(), info.isResumable(),
- notificationInfo.isAutoResumable, info.getIsTransient());
+ notificationInfo.isAutoResumable, info.getIsTransient(), info.getIcon());
break;
case DOWNLOAD_NOTIFICATION_TYPE_SUCCESS:
final int notificationId = mBoundService.notifyDownloadSuccessful(
info.getContentId(), info.getFilePath(), info.getFileName(),
notificationInfo.systemDownloadId, info.isOffTheRecord(),
- notificationInfo.isSupportedMimeType, info.getIsOpenable());
+ notificationInfo.isSupportedMimeType, info.getIsOpenable(), info.getIcon());
onSuccessNotificationShown(notificationInfo, notificationId);
break;
case DOWNLOAD_NOTIFICATION_TYPE_FAILURE:
- mBoundService.notifyDownloadFailed(info.getContentId(), info.getFileName());
+ mBoundService.notifyDownloadFailed(
+ info.getContentId(), info.getFileName(), info.getIcon());
break;
case DOWNLOAD_NOTIFICATION_TYPE_CANCEL:
mBoundService.notifyDownloadCanceled(info.getContentId());

Powered by Google App Engine
This is Rietveld 408576698