Add support for pulling icons for OfflineItems

components/offline_items_collection/core/offline_item.h

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_OFFLINE_ITEMS_COLLECTION_CORE_OFFLINE_ITEM_H_
 #define COMPONENTS_OFFLINE_ITEMS_COLLECTION_CORE_OFFLINE_ITEM_H_
 
 #include <string>
 
 #include "base/time/time.h"
 #include "components/offline_items_collection/core/offline_item_filter.h"
 #include "components/offline_items_collection/core/offline_item_state.h"
+#include "ui/gfx/image/image.h"
 #include "url/gurl.h"
 
 namespace offline_items_collection {
 
 // An id that uniquely represents a piece of offline content.
 struct ContentId {
   // The namespace for the offline content.  This will be used to associate this
   // id with a particular OfflineContentProvider.  A name_space can include
   // any characters except ','.  This is due to a serialization format
   // limitation.
@@ skipping 103 matching lines @@
   // indeterminate progress bar should be used.  This field is not used if
   // |state| is COMPLETE.
   int percent_completed;
 
   // The estimated time remaining for the download in milliseconds.  -1
   // represents an unknown time remaining.  This field is not used if |state| is
   // COMPLETE.
   int64_t time_remaining_ms;
 };
 
+// This struct holds any potentially expensive visuals for an OfflineItem.  If
+// the front end requires the visuals it will ask for them through the
+// OfflineContentProvider interface asynchronously to give the backend time to
+// generate them if necessary.
+//
+// It is not expected that these will change.  Currently the UI might cache the
+// results of this call.
+// TODO(dtrainor): If we run into a scenario where this changes, add a way for
+// an OfflineItem update to let us know about an update to the visuals.
+struct OfflineItemVisuals {
+  OfflineItemVisuals();
+  OfflineItemVisuals(const OfflineItemVisuals& other);
+
+  ~OfflineItemVisuals();
+
+  // The icon to use for displaying this item.  The icon should be 64dp x 64dp.
+  // Can be |nullptr| if there is no valid icon for this item.

[nyquist, 2017/04/13 05:08:25]

Is gfx::Image a pointer?

[David Trainor- moved to gerrit, 2017/04/13 07:20:23]

:/ crap yeah I changed it once I realized the internal storage was ref counted.

+  // TODO(dtrainor): Suggest icon size based on the icon size supported by the
+  // current OS.
+  gfx::Image icon;
+};
+
 }  // namespace offline_items_collection
 
 #endif  // COMPONENTS_OFFLINE_ITEMS_COLLECTION_OFFLINE_ITEM_H_