Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Side by Side Diff: chrome/browser/ui/cocoa/tabs/tab_window_controller.mm

Issue 2811793002: Turn off Auto Layout pending investigation of a performance regression. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_controller_unittest.mm ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "chrome/browser/ui/cocoa/tabs/tab_window_controller.h" 5 #import "chrome/browser/ui/cocoa/tabs/tab_window_controller.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #import "base/mac/sdk_forward_declarations.h" 8 #import "base/mac/sdk_forward_declarations.h"
9 #import "chrome/browser/ui/cocoa/browser_window_layout.h" 9 #import "chrome/browser/ui/cocoa/browser_window_layout.h"
10 #import "chrome/browser/ui/cocoa/fast_resize_view.h" 10 #import "chrome/browser/ui/cocoa/fast_resize_view.h"
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
69 69
70 @implementation ChromeContentView 70 @implementation ChromeContentView
71 71
72 // NSView overrides. 72 // NSView overrides.
73 73
74 // Since Auto Layout and frame-based layout behave differently in small but 74 // Since Auto Layout and frame-based layout behave differently in small but
75 // important ways (e.g. Auto Layout can restrict window resizing, frame-based 75 // important ways (e.g. Auto Layout can restrict window resizing, frame-based
76 // layout doesn't log a warning when a view's autoresizing mask can't be 76 // layout doesn't log a warning when a view's autoresizing mask can't be
77 // maintained), ensure that it's on instead of letting it depend on content. 77 // maintained), ensure that it's on instead of letting it depend on content.
78 + (BOOL)requiresConstraintBasedLayout { 78 + (BOOL)requiresConstraintBasedLayout {
79 return YES; 79 // TODO(sdy): Turn back on (or remove) after investigating a performance
80 // regression: https://crbug.com/706931
81 return NO;
80 } 82 }
81 83
82 @end 84 @end
83 85
84 @implementation TabWindowController 86 @implementation TabWindowController
85 87
86 - (id)initTabWindowControllerWithTabStrip:(BOOL)hasTabStrip 88 - (id)initTabWindowControllerWithTabStrip:(BOOL)hasTabStrip
87 titleBar:(BOOL)hasTitleBar { 89 titleBar:(BOOL)hasTitleBar {
88 const CGFloat kDefaultWidth = 750; 90 const CGFloat kDefaultWidth = 750;
89 const CGFloat kDefaultHeight = 600; 91 const CGFloat kDefaultHeight = 600;
(...skipping 388 matching lines...) Expand 10 before | Expand all | Expand 10 after
478 480
479 - (void)windowWillEnterFullScreenNotification:(NSNotification*)notification { 481 - (void)windowWillEnterFullScreenNotification:(NSNotification*)notification {
480 [[visualEffectView_ animator] setAlphaValue:0.0]; 482 [[visualEffectView_ animator] setAlphaValue:0.0];
481 } 483 }
482 484
483 - (void)windowWillExitFullScreenNotification:(NSNotification*)notification { 485 - (void)windowWillExitFullScreenNotification:(NSNotification*)notification {
484 [[visualEffectView_ animator] setAlphaValue:1.0]; 486 [[visualEffectView_ animator] setAlphaValue:1.0];
485 } 487 }
486 488
487 @end 489 @end
OLDNEW
« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_controller_unittest.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698