base/metrics/persistent_sample_map.cc - Issue 2811713003: Embed a single sample in histogram metadata.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/metrics/persistent_sample_map.cc

Issue 2811713003: Embed a single sample in histogram metadata. (Closed)

Patch Set: addressed review comments by asvitkine Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/metrics/persistent_sample_map.cc

diff --git a/base/metrics/persistent_sample_map.cc b/base/metrics/persistent_sample_map.cc

index 51cc0c709d8b0d9087c75d64c512b06e434f6ba7..9fb0ff8ef700a3d23b0e9b3c8da75146728a485d 100644

--- a/base/metrics/persistent_sample_map.cc

+++ b/base/metrics/persistent_sample_map.cc

@@ -115,8 +115,7 @@ PersistentSampleMap::~PersistentSampleMap() {

void PersistentSampleMap::Accumulate(Sample value, Count count) {

*GetOrCreateSampleCountStorage(value) += count;

- IncreaseSum(static_cast<int64_t>(count) * value);

- IncreaseRedundantCount(count);

+ IncreaseSumAndCount(static_cast<int64_t>(count) * value, count);

}

Count PersistentSampleMap::GetCount(Sample value) const {