Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Unified Diff: gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc

Issue 2811693005: Handle pixel (un)pack buffers with non-zero offset. (Closed)
Patch Set: Address comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc
diff --git a/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc b/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc
index d602360c369fbf5981ce8050b6f0eeb0b74b56a8..842e1d9e1ce20e19660c81e041ac1544715c51fa 100644
--- a/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc
+++ b/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc
@@ -466,10 +466,13 @@ error::Error GLES2DecoderPassthroughImpl::DoCompressedTexImage2D(
GLsizei width,
GLsizei height,
GLint border,
- GLsizei imageSize,
+ GLsizei image_size,
+ GLsizei data_size,
const void* data) {
+ // TODO(cwallez@chromium.org): Use data_size with the robust version of the
+ // entry point
glCompressedTexImage2D(target, level, internalformat, width, height, border,
- imageSize, data);
+ image_size, data);
return error::kNoError;
}
@@ -481,10 +484,13 @@ error::Error GLES2DecoderPassthroughImpl::DoCompressedTexSubImage2D(
GLsizei width,
GLsizei height,
GLenum format,
- GLsizei imageSize,
+ GLsizei image_size,
+ GLsizei data_size,
const void* data) {
+ // TODO(cwallez@chromium.org): Use data_size with the robust version of the
+ // entry point
glCompressedTexSubImage2D(target, level, xoffset, yoffset, width, height,
- format, imageSize, data);
+ format, image_size, data);
return error::kNoError;
}
@@ -496,10 +502,13 @@ error::Error GLES2DecoderPassthroughImpl::DoCompressedTexImage3D(
GLsizei height,
GLsizei depth,
GLint border,
- GLsizei imageSize,
+ GLsizei image_size,
+ GLsizei data_size,
const void* data) {
+ // TODO(cwallez@chromium.org): Use data_size with the robust version of the
+ // entry point
glCompressedTexImage3D(target, level, internalformat, width, height, depth,
- border, imageSize, data);
+ border, image_size, data);
return error::kNoError;
}
@@ -513,10 +522,13 @@ error::Error GLES2DecoderPassthroughImpl::DoCompressedTexSubImage3D(
GLsizei height,
GLsizei depth,
GLenum format,
- GLsizei imageSize,
+ GLsizei image_size,
+ GLsizei data_size,
const void* data) {
+ // TODO(cwallez@chromium.org): Use data_size with the robust version of the
+ // entry point
glCompressedTexSubImage3D(target, level, xoffset, yoffset, zoffset, width,
- height, depth, format, imageSize, data);
+ height, depth, format, image_size, data);
return error::kNoError;
}

Powered by Google App Engine
This is Rietveld 408576698