Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6937)

Unified Diff: chrome/browser/extensions/menu_manager.cc

Issue 2811673002: Reland: Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions (Closed)
Patch Set: Workaround with std::move Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/install_signer.cc ('k') | chrome/browser/extensions/menu_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/menu_manager.cc
diff --git a/chrome/browser/extensions/menu_manager.cc b/chrome/browser/extensions/menu_manager.cc
index d53fb2341b1194e21b505b7d846cebcd54c4d81c..dc1abda3af58c2b0a44833209da90d3ea32761af 100644
--- a/chrome/browser/extensions/menu_manager.cc
+++ b/chrome/browser/extensions/menu_manager.cc
@@ -209,14 +209,13 @@ std::unique_ptr<base::DictionaryValue> MenuItem::ToValue() const {
if (type_ == CHECKBOX || type_ == RADIO)
value->SetBoolean(kCheckedKey, checked_);
value->SetBoolean(kEnabledKey, enabled_);
- value->Set(kContextsKey, contexts_.ToValue().release());
+ value->Set(kContextsKey, contexts_.ToValue());
if (parent_id_) {
DCHECK_EQ(0, parent_id_->uid);
value->SetString(kParentUIDKey, parent_id_->string_uid);
}
- value->Set(kDocumentURLPatternsKey,
- document_url_patterns_.ToValue().release());
- value->Set(kTargetURLPatternsKey, target_url_patterns_.ToValue().release());
+ value->Set(kDocumentURLPatternsKey, document_url_patterns_.ToValue());
+ value->Set(kTargetURLPatternsKey, target_url_patterns_.ToValue());
return value;
}
« no previous file with comments | « chrome/browser/extensions/install_signer.cc ('k') | chrome/browser/extensions/menu_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698