chrome/browser/extensions/external_pref_loader.cc - Issue 2811673002: Reland: Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/external_pref_loader.cc

Issue 2811673002: Reland: Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions (Closed)

Patch Set: Workaround with std::move Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/external_pref_loader.cc

diff --git a/chrome/browser/extensions/external_pref_loader.cc b/chrome/browser/extensions/external_pref_loader.cc

index f289f827a1708c6ee90a55b85ed7579774245d79..fb3f85f0688a838e3f52e63eee8bec4f5dd41f70 100644

--- a/chrome/browser/extensions/external_pref_loader.cc

+++ b/chrome/browser/extensions/external_pref_loader.cc

@@ -305,7 +305,7 @@ void ExternalPrefLoader::ReadStandaloneExtensionPrefFiles(

ExtractExtensionPrefs(&deserializer, extension_candidate_path);

if (ext_prefs) {

DVLOG(1) << "Adding extension with id: " << id;

- prefs->Set(id, ext_prefs.release());

+ prefs->Set(id, std::move(ext_prefs));

}