Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Unified Diff: chrome/browser/extensions/extension_special_storage_policy_unittest.cc

Issue 2811673002: Reland: Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions (Closed)
Patch Set: Workaround with std::move Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_special_storage_policy_unittest.cc
diff --git a/chrome/browser/extensions/extension_special_storage_policy_unittest.cc b/chrome/browser/extensions/extension_special_storage_policy_unittest.cc
index 1916e307c259080188c33a1c7abeca14df517d1d..b37c1867693e060158f57a02d70bd9478c236b1a 100644
--- a/chrome/browser/extensions/extension_special_storage_policy_unittest.cc
+++ b/chrome/browser/extensions/extension_special_storage_policy_unittest.cc
@@ -4,7 +4,10 @@
#include <stddef.h>
+#include <utility>
+
#include "base/macros.h"
+#include "base/memory/ptr_util.h"
#include "base/run_loop.h"
#include "base/values.h"
#include "build/build_config.h"
@@ -109,10 +112,10 @@ class ExtensionSpecialStoragePolicyTest : public testing::Test {
manifest.SetString(keys::kName, "Protected");
manifest.SetString(keys::kVersion, "1");
manifest.SetString(keys::kLaunchWebURL, "http://explicit/protected/start");
- base::ListValue* list = new base::ListValue();
+ auto list = base::MakeUnique<base::ListValue>();
list->AppendString("http://explicit/protected");
list->AppendString("*://*.wildcards/protected");
- manifest.Set(keys::kWebURLs, list);
+ manifest.Set(keys::kWebURLs, std::move(list));
std::string error;
scoped_refptr<Extension> protected_app = Extension::Create(
path, Manifest::INVALID_LOCATION, manifest,
@@ -131,13 +134,13 @@ class ExtensionSpecialStoragePolicyTest : public testing::Test {
manifest.SetString(keys::kName, "Unlimited");
manifest.SetString(keys::kVersion, "1");
manifest.SetString(keys::kLaunchWebURL, "http://explicit/unlimited/start");
- base::ListValue* list = new base::ListValue();
+ auto list = base::MakeUnique<base::ListValue>();
list->AppendString("unlimitedStorage");
- manifest.Set(keys::kPermissions, list);
- list = new base::ListValue();
+ manifest.Set(keys::kPermissions, std::move(list));
+ list = base::MakeUnique<base::ListValue>();
list->AppendString("http://explicit/unlimited");
list->AppendString("*://*.wildcards/unlimited");
- manifest.Set(keys::kWebURLs, list);
+ manifest.Set(keys::kWebURLs, std::move(list));
std::string error;
scoped_refptr<Extension> unlimited_app = Extension::Create(
path, Manifest::INVALID_LOCATION, manifest,
« no previous file with comments | « chrome/browser/extensions/extension_service_unittest.cc ('k') | chrome/browser/extensions/extension_web_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698