Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2401)

Unified Diff: chrome/browser/extensions/extension_protocols_unittest.cc

Issue 2811673002: Reland: Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions (Closed)
Patch Set: Workaround with std::move Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_protocols_unittest.cc
diff --git a/chrome/browser/extensions/extension_protocols_unittest.cc b/chrome/browser/extensions/extension_protocols_unittest.cc
index ae5afc90b0cb4d1bea70ae405b9dfcb3a97854bd..b2019ed346046cd7db5651d8908e51830bb5c231 100644
--- a/chrome/browser/extensions/extension_protocols_unittest.cc
+++ b/chrome/browser/extensions/extension_protocols_unittest.cc
@@ -6,10 +6,12 @@
#include <memory>
#include <string>
+#include <utility>
#include "base/command_line.h"
#include "base/files/file_util.h"
#include "base/macros.h"
+#include "base/memory/ptr_util.h"
#include "base/run_loop.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/string_util.h"
@@ -103,9 +105,9 @@ scoped_refptr<Extension> CreateTestResponseHeaderExtension() {
manifest.SetString("name", "An extension with web-accessible resources");
manifest.SetString("version", "2");
- base::ListValue* web_accessible_list = new base::ListValue();
+ auto web_accessible_list = base::MakeUnique<base::ListValue>();
web_accessible_list->AppendString("test.dat");
- manifest.Set("web_accessible_resources", web_accessible_list);
+ manifest.Set("web_accessible_resources", std::move(web_accessible_list));
base::FilePath path = GetTestPath("response_headers");
« no previous file with comments | « chrome/browser/extensions/extension_prefs_unittest.cc ('k') | chrome/browser/extensions/extension_service_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698