chrome/browser/extensions/api/sync_file_system/extension_sync_event_observer.cc - Issue 2811673002: Reland: Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/sync_file_system/extension_sync_event_observer.cc

Issue 2811673002: Reland: Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions (Closed)

Patch Set: Workaround with std::move Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/storage/settings_sync_unittest.cc ('k') | chrome/browser/extensions/api/sync_file_system/sync_file_system_api_helpers.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/sync_file_system/extension_sync_event_observer.cc

diff --git a/chrome/browser/extensions/api/sync_file_system/extension_sync_event_observer.cc b/chrome/browser/extensions/api/sync_file_system/extension_sync_event_observer.cc

index 0fa12ebafb14a1d74d240eefe8523a79ee4f1629..eb46006f4f0367ad27321fd6cf700a2902638f50 100644

--- a/chrome/browser/extensions/api/sync_file_system/extension_sync_event_observer.cc

+++ b/chrome/browser/extensions/api/sync_file_system/extension_sync_event_observer.cc

@@ -94,8 +94,8 @@ void ExtensionSyncEventObserver::OnFileSynced(

sync_file_system::SyncDirection direction) {

std::unique_ptr<base::ListValue> params(new base::ListValue());

- std::unique_ptr<base::DictionaryValue> entry(

- CreateDictionaryValueForFileSystemEntry(url, file_type));

+ std::unique_ptr<base::DictionaryValue> entry =

+ CreateDictionaryValueForFileSystemEntry(url, file_type);

if (!entry)

return;

params->Append(std::move(entry));