chrome/browser/extensions/api/storage/policy_value_store.cc - Issue 2811673002: Reland: Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/storage/policy_value_store.cc

Issue 2811673002: Reland: Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions (Closed)

Patch Set: Workaround with std::move Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/storage/policy_value_store.cc

diff --git a/chrome/browser/extensions/api/storage/policy_value_store.cc b/chrome/browser/extensions/api/storage/policy_value_store.cc

index 5fd0826464381c6d3aa97cc7ca7d31c69bea9960..02ceaafbb0d8504293a626c564da66bc10975f5a 100644

--- a/chrome/browser/extensions/api/storage/policy_value_store.cc

+++ b/chrome/browser/extensions/api/storage/policy_value_store.cc

@@ -46,7 +46,7 @@ void PolicyValueStore::SetCurrentPolicy(const policy::PolicyMap& policy) {

it != policy.end(); ++it) {

if (it->second.level == policy::POLICY_LEVEL_MANDATORY) {

current_policy.SetWithoutPathExpansion(

- it->first, it->second.value->DeepCopy());

+ it->first, it->second.value->CreateDeepCopy());

}