Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4543)

Unified Diff: chrome/browser/extensions/api/proxy/proxy_api.h

Issue 2811673002: Reland: Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions (Closed)
Patch Set: Workaround with std::move Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/proxy/proxy_api.h
diff --git a/chrome/browser/extensions/api/proxy/proxy_api.h b/chrome/browser/extensions/api/proxy/proxy_api.h
index f3c3fb5afe31f1ac0d7174b347dcab4346cfba58..d10fe758609b2f78cb14faeb042e7a2fb5098735 100644
--- a/chrome/browser/extensions/api/proxy/proxy_api.h
+++ b/chrome/browser/extensions/api/proxy/proxy_api.h
@@ -32,10 +32,12 @@ class ProxyPrefTransformer : public PrefTransformerInterface {
~ProxyPrefTransformer() override;
// Implementation of PrefTransformerInterface.
- base::Value* ExtensionToBrowserPref(const base::Value* extension_pref,
- std::string* error,
- bool* bad_message) override;
- base::Value* BrowserToExtensionPref(const base::Value* browser_pref) override;
+ std::unique_ptr<base::Value> ExtensionToBrowserPref(
+ const base::Value* extension_pref,
+ std::string* error,
+ bool* bad_message) override;
+ std::unique_ptr<base::Value> BrowserToExtensionPref(
+ const base::Value* browser_pref) override;
private:
DISALLOW_COPY_AND_ASSIGN(ProxyPrefTransformer);
« no previous file with comments | « chrome/browser/extensions/api/preference/preference_api.cc ('k') | chrome/browser/extensions/api/proxy/proxy_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698