chrome/browser/extensions/api/preference/chrome_direct_setting.cc - Issue 2811673002: Reland: Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/preference/chrome_direct_setting.cc

Issue 2811673002: Reland: Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions (Closed)

Patch Set: Workaround with std::move Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/preference/chrome_direct_setting.cc

diff --git a/chrome/browser/extensions/api/preference/chrome_direct_setting.cc b/chrome/browser/extensions/api/preference/chrome_direct_setting.cc

index a612d302aaf542ce55deb30499021975a55ef016..db511d051b8c33481058eb09030d63471477fe48 100644

--- a/chrome/browser/extensions/api/preference/chrome_direct_setting.cc

+++ b/chrome/browser/extensions/api/preference/chrome_direct_setting.cc

@@ -39,7 +39,7 @@ ExtensionFunction::ResponseAction GetDirectSettingFunction::Run() {

const base::Value* value = preference->GetValue();

std::unique_ptr<base::DictionaryValue> result(new base::DictionaryValue);

- result->Set(preference_api_constants::kValue, value->DeepCopy());

+ result->Set(preference_api_constants::kValue, value->CreateDeepCopy());

return RespondNow(OneArgument(std::move(result)));

}