Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2971)

Unified Diff: chrome/browser/extensions/api/downloads/downloads_api.cc

Issue 2811673002: Reland: Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions (Closed)
Patch Set: Workaround with std::move Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/downloads/downloads_api.cc
diff --git a/chrome/browser/extensions/api/downloads/downloads_api.cc b/chrome/browser/extensions/api/downloads/downloads_api.cc
index 177fbdc96eee17f8348f731e32a30b7091e7e5e1..0c9d52254e5d366289dd3a4bcb9df908bb3b1a87 100644
--- a/chrome/browser/extensions/api/downloads/downloads_api.cc
+++ b/chrome/browser/extensions/api/downloads/downloads_api.cc
@@ -1824,9 +1824,9 @@ void ExtensionDownloadsEventRouter::OnDownloadUpdated(
if (!data->json().HasKey(iter.key()) ||
(data->json().Get(iter.key(), &old_value) &&
!iter.value().Equals(old_value))) {
- delta->Set(iter.key() + ".current", iter.value().DeepCopy());
+ delta->Set(iter.key() + ".current", iter.value().CreateDeepCopy());
if (old_value)
- delta->Set(iter.key() + ".previous", old_value->DeepCopy());
+ delta->Set(iter.key() + ".previous", old_value->CreateDeepCopy());
changed = true;
}
}
@@ -1839,7 +1839,7 @@ void ExtensionDownloadsEventRouter::OnDownloadUpdated(
if ((new_fields.find(iter.key()) == new_fields.end()) &&
IsDownloadDeltaField(iter.key())) {
// estimatedEndTime disappears after completion, but bytesReceived stays.
- delta->Set(iter.key() + ".previous", iter.value().DeepCopy());
+ delta->Set(iter.key() + ".previous", iter.value().CreateDeepCopy());
changed = true;
}
}

Powered by Google App Engine
This is Rietveld 408576698