chrome/browser/extensions/api/debugger/debugger_api.cc - Issue 2811673002: Reland: Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/debugger/debugger_api.cc

Issue 2811673002: Reland: Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions (Closed)

Patch Set: Workaround with std::move Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/debugger/debugger_api.cc

diff --git a/chrome/browser/extensions/api/debugger/debugger_api.cc b/chrome/browser/extensions/api/debugger/debugger_api.cc

index 88d7f073bdee31a7751c8025b06fcbdd4b995e03..2e48eb88dff27461fe49e6cb6ffeadcb74b09023 100644

--- a/chrome/browser/extensions/api/debugger/debugger_api.cc

+++ b/chrome/browser/extensions/api/debugger/debugger_api.cc

@@ -391,8 +391,8 @@ void ExtensionDevToolsClientHost::SendMessageToBackend(

protocol_request.SetInteger("id", request_id);

protocol_request.SetString("method", method);

if (command_params) {

- protocol_request.Set("params",

- command_params->additional_properties.DeepCopy());

+ protocol_request.Set(

+ "params", command_params->additional_properties.CreateDeepCopy());

}

std::string json_args;