Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1524)

Unified Diff: chrome/browser/extensions/api/browsing_data/browsing_data_api.cc

Issue 2811673002: Reland: Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions (Closed)
Patch Set: Workaround with std::move Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/browsing_data/browsing_data_api.cc
diff --git a/chrome/browser/extensions/api/browsing_data/browsing_data_api.cc b/chrome/browser/extensions/api/browsing_data/browsing_data_api.cc
index 00c27fc6b9ed16419f2a8630c643f20d31d1fd67..584ac30c335304a0000613371efd03a862afc3b7 100644
--- a/chrome/browser/extensions/api/browsing_data/browsing_data_api.cc
+++ b/chrome/browser/extensions/api/browsing_data/browsing_data_api.cc
@@ -153,7 +153,7 @@ ExtensionFunction::ResponseAction BrowsingDataSettingsFunction::Run() {
std::unique_ptr<base::DictionaryValue> options(new base::DictionaryValue);
options->Set(extension_browsing_data_api_constants::kOriginTypesKey,
- origin_types.release());
+ std::move(origin_types));
options->SetDouble(extension_browsing_data_api_constants::kSinceKey, since);
// Fill dataToRemove and dataRemovalPermitted.
@@ -215,11 +215,11 @@ ExtensionFunction::ResponseAction BrowsingDataSettingsFunction::Run() {
std::unique_ptr<base::DictionaryValue> result(new base::DictionaryValue);
result->Set(extension_browsing_data_api_constants::kOptionsKey,
- options.release());
+ std::move(options));
result->Set(extension_browsing_data_api_constants::kDataToRemoveKey,
- selected.release());
+ std::move(selected));
result->Set(extension_browsing_data_api_constants::kDataRemovalPermittedKey,
- permitted.release());
+ std::move(permitted));
return RespondNow(OneArgument(std::move(result)));
}
« no previous file with comments | « chrome/browser/extensions/api/bookmarks/bookmark_apitest.cc ('k') | chrome/browser/extensions/api/commands/command_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698