Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Unified Diff: chrome/browser/extensions/activity_log/counting_policy_unittest.cc

Issue 2811673002: Reland: Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions (Closed)
Patch Set: Workaround with std::move Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/activity_log/counting_policy_unittest.cc
diff --git a/chrome/browser/extensions/activity_log/counting_policy_unittest.cc b/chrome/browser/extensions/activity_log/counting_policy_unittest.cc
index cad7e143e8b8938a695fe04665cbfce8d0a181e8..0c8601fdeb8474782246aa6f3012f2e05b15bea5 100644
--- a/chrome/browser/extensions/activity_log/counting_policy_unittest.cc
+++ b/chrome/browser/extensions/activity_log/counting_policy_unittest.cc
@@ -22,6 +22,7 @@
#include "base/test/simple_test_clock.h"
#include "base/test/test_timeouts.h"
#include "base/threading/thread_task_runner_handle.h"
+#include "base/values.h"
#include "build/build_config.h"
#include "chrome/browser/extensions/activity_log/activity_log.h"
#include "chrome/browser/extensions/extension_service.h"
@@ -433,8 +434,8 @@ TEST_F(CountingPolicyTest, LogWithStrippedArguments) {
extension_service_->AddExtension(extension.get());
std::unique_ptr<base::ListValue> args(new base::ListValue());
- args->Set(0, new base::Value("hello"));
- args->Set(1, new base::Value("world"));
+ args->Set(0, base::MakeUnique<base::Value>("hello"));
+ args->Set(1, base::MakeUnique<base::Value>("world"));
scoped_refptr<Action> action = new Action(extension->id(),
base::Time::Now(),
Action::ACTION_API_CALL,

Powered by Google App Engine
This is Rietveld 408576698