Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1401)

Unified Diff: chrome/browser/devtools/devtools_window.cc

Issue 2811673002: Reland: Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions (Closed)
Patch Set: Workaround with std::move Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/devtools/devtools_window.cc
diff --git a/chrome/browser/devtools/devtools_window.cc b/chrome/browser/devtools/devtools_window.cc
index fddbd76c5c0e55765b9d1555deb119561186bb83..6993861a1ba083cce729f2dba7efe8c5a7430e08 100644
--- a/chrome/browser/devtools/devtools_window.cc
+++ b/chrome/browser/devtools/devtools_window.cc
@@ -5,10 +5,12 @@
#include "chrome/browser/devtools/devtools_window.h"
#include <algorithm>
+#include <utility>
#include "base/command_line.h"
#include "base/json/json_reader.h"
#include "base/macros.h"
+#include "base/memory/ptr_util.h"
#include "base/metrics/histogram_macros.h"
#include "base/metrics/user_metrics.h"
#include "base/time/time.h"
@@ -1307,14 +1309,14 @@ void DevToolsWindow::CreateDevToolsBrowser() {
if (!prefs->GetDictionary(prefs::kAppWindowPlacement)->HasKey(kDevToolsApp)) {
DictionaryPrefUpdate update(prefs, prefs::kAppWindowPlacement);
base::DictionaryValue* wp_prefs = update.Get();
- base::DictionaryValue* dev_tools_defaults = new base::DictionaryValue;
- wp_prefs->Set(kDevToolsApp, dev_tools_defaults);
+ auto dev_tools_defaults = base::MakeUnique<base::DictionaryValue>();
dev_tools_defaults->SetInteger("left", 100);
dev_tools_defaults->SetInteger("top", 100);
dev_tools_defaults->SetInteger("right", 740);
dev_tools_defaults->SetInteger("bottom", 740);
dev_tools_defaults->SetBoolean("maximized", false);
dev_tools_defaults->SetBoolean("always_on_top", false);
+ wp_prefs->Set(kDevToolsApp, std::move(dev_tools_defaults));
}
browser_ = new Browser(Browser::CreateParams::CreateForDevTools(profile_));
« no previous file with comments | « chrome/browser/devtools/devtools_ui_bindings.cc ('k') | chrome/browser/extensions/activity_log/activity_log.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698