OLD | NEW |
1 // Copyright 2013 The Chromium Authors. All rights reserved. | 1 // Copyright 2013 The Chromium Authors. All rights reserved. |
2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
4 | 4 |
5 #include "chrome/browser/extensions/api/activity_log_private/activity_log_privat
e_api.h" | 5 #include "chrome/browser/extensions/api/activity_log_private/activity_log_privat
e_api.h" |
6 | 6 |
7 #include <memory> | 7 #include <memory> |
8 #include <string> | 8 #include <string> |
9 #include <utility> | 9 #include <utility> |
10 | 10 |
| 11 #include "base/memory/ptr_util.h" |
11 #include "base/strings/utf_string_conversions.h" | 12 #include "base/strings/utf_string_conversions.h" |
| 13 #include "base/values.h" |
12 #include "chrome/browser/extensions/activity_log/activity_action_constants.h" | 14 #include "chrome/browser/extensions/activity_log/activity_action_constants.h" |
13 #include "testing/gtest/include/gtest/gtest.h" | 15 #include "testing/gtest/include/gtest/gtest.h" |
14 | 16 |
15 namespace { | 17 namespace { |
16 | 18 |
17 const char kExtensionId[] = "extensionid"; | 19 const char kExtensionId[] = "extensionid"; |
18 const char kApiCall[] = "api.call"; | 20 const char kApiCall[] = "api.call"; |
19 const char kArgs[] = "[\"hello\",\"world\"]"; | 21 const char kArgs[] = "[\"hello\",\"world\"]"; |
20 | 22 |
21 } // extensions | 23 } // extensions |
22 | 24 |
23 namespace extensions { | 25 namespace extensions { |
24 | 26 |
25 using api::activity_log_private::ExtensionActivity; | 27 using api::activity_log_private::ExtensionActivity; |
26 | 28 |
27 typedef testing::Test ActivityLogApiUnitTest; | 29 typedef testing::Test ActivityLogApiUnitTest; |
28 | 30 |
29 TEST_F(ActivityLogApiUnitTest, ConvertChromeApiAction) { | 31 TEST_F(ActivityLogApiUnitTest, ConvertChromeApiAction) { |
30 std::unique_ptr<base::ListValue> args(new base::ListValue()); | 32 std::unique_ptr<base::ListValue> args(new base::ListValue()); |
31 args->Set(0, new base::Value("hello")); | 33 args->Set(0, base::MakeUnique<base::Value>("hello")); |
32 args->Set(1, new base::Value("world")); | 34 args->Set(1, base::MakeUnique<base::Value>("world")); |
33 scoped_refptr<Action> action(new Action(kExtensionId, | 35 scoped_refptr<Action> action(new Action(kExtensionId, |
34 base::Time::Now(), | 36 base::Time::Now(), |
35 Action::ACTION_API_CALL, | 37 Action::ACTION_API_CALL, |
36 kApiCall)); | 38 kApiCall)); |
37 action->set_args(std::move(args)); | 39 action->set_args(std::move(args)); |
38 ExtensionActivity result = action->ConvertToExtensionActivity(); | 40 ExtensionActivity result = action->ConvertToExtensionActivity(); |
39 ASSERT_EQ(api::activity_log_private::EXTENSION_ACTIVITY_TYPE_API_CALL, | 41 ASSERT_EQ(api::activity_log_private::EXTENSION_ACTIVITY_TYPE_API_CALL, |
40 result.activity_type); | 42 result.activity_type); |
41 ASSERT_EQ(kExtensionId, *(result.extension_id.get())); | 43 ASSERT_EQ(kExtensionId, *(result.extension_id.get())); |
42 ASSERT_EQ(kApiCall, *(result.api_call.get())); | 44 ASSERT_EQ(kApiCall, *(result.api_call.get())); |
43 ASSERT_EQ(kArgs, *(result.args.get())); | 45 ASSERT_EQ(kArgs, *(result.args.get())); |
44 ASSERT_EQ(NULL, result.activity_id.get()); | 46 ASSERT_EQ(NULL, result.activity_id.get()); |
45 } | 47 } |
46 | 48 |
47 TEST_F(ActivityLogApiUnitTest, ConvertDomAction) { | 49 TEST_F(ActivityLogApiUnitTest, ConvertDomAction) { |
48 std::unique_ptr<base::ListValue> args(new base::ListValue()); | 50 std::unique_ptr<base::ListValue> args(new base::ListValue()); |
49 args->Set(0, new base::Value("hello")); | 51 args->Set(0, base::MakeUnique<base::Value>("hello")); |
50 args->Set(1, new base::Value("world")); | 52 args->Set(1, base::MakeUnique<base::Value>("world")); |
51 scoped_refptr<Action> action(new Action(kExtensionId, | 53 scoped_refptr<Action> action(new Action(kExtensionId, |
52 base::Time::Now(), | 54 base::Time::Now(), |
53 Action::ACTION_DOM_ACCESS, | 55 Action::ACTION_DOM_ACCESS, |
54 kApiCall, | 56 kApiCall, |
55 12345)); | 57 12345)); |
56 action->set_args(std::move(args)); | 58 action->set_args(std::move(args)); |
57 action->set_page_url(GURL("http://www.google.com")); | 59 action->set_page_url(GURL("http://www.google.com")); |
58 action->set_page_title("Title"); | 60 action->set_page_title("Title"); |
59 action->mutable_other()->SetInteger(activity_log_constants::kActionDomVerb, | 61 action->mutable_other()->SetInteger(activity_log_constants::kActionDomVerb, |
60 DomActionType::INSERTED); | 62 DomActionType::INSERTED); |
61 action->mutable_other()->SetBoolean(activity_log_constants::kActionPrerender, | 63 action->mutable_other()->SetBoolean(activity_log_constants::kActionPrerender, |
62 false); | 64 false); |
63 ExtensionActivity result = action->ConvertToExtensionActivity(); | 65 ExtensionActivity result = action->ConvertToExtensionActivity(); |
64 ASSERT_EQ(kExtensionId, *(result.extension_id.get())); | 66 ASSERT_EQ(kExtensionId, *(result.extension_id.get())); |
65 ASSERT_EQ("http://www.google.com/", *(result.page_url.get())); | 67 ASSERT_EQ("http://www.google.com/", *(result.page_url.get())); |
66 ASSERT_EQ("Title", *(result.page_title.get())); | 68 ASSERT_EQ("Title", *(result.page_title.get())); |
67 ASSERT_EQ(kApiCall, *(result.api_call.get())); | 69 ASSERT_EQ(kApiCall, *(result.api_call.get())); |
68 ASSERT_EQ(kArgs, *(result.args.get())); | 70 ASSERT_EQ(kArgs, *(result.args.get())); |
69 std::unique_ptr<ExtensionActivity::Other> other(std::move(result.other)); | 71 std::unique_ptr<ExtensionActivity::Other> other(std::move(result.other)); |
70 ASSERT_EQ(api::activity_log_private::EXTENSION_ACTIVITY_DOM_VERB_INSERTED, | 72 ASSERT_EQ(api::activity_log_private::EXTENSION_ACTIVITY_DOM_VERB_INSERTED, |
71 other->dom_verb); | 73 other->dom_verb); |
72 ASSERT_TRUE(other->prerender.get()); | 74 ASSERT_TRUE(other->prerender.get()); |
73 ASSERT_EQ("12345", *(result.activity_id.get())); | 75 ASSERT_EQ("12345", *(result.activity_id.get())); |
74 } | 76 } |
75 | 77 |
76 } // namespace extensions | 78 } // namespace extensions |
OLD | NEW |