Reland: Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions

chrome/browser/component_updater/supervised_user_whitelist_installer.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/component_updater/supervised_user_whitelist_installer.h"
 
 #include <stddef.h>
 
 #include <map>
 #include <utility>
@@ skipping 515 matching lines @@
   return callbacks_.push_back(callback);
 }
 
 void SupervisedUserWhitelistInstallerImpl::RegisterWhitelist(
     const std::string& client_id,
     const std::string& crx_id,
     const std::string& name) {
   DictionaryPrefUpdate update(local_state_,
                               prefs::kRegisteredSupervisedUserWhitelists);
   base::DictionaryValue* pref_dict = update.Get();
-  base::DictionaryValue* whitelist_dict = nullptr;
-  const bool newly_added =
-      !pref_dict->GetDictionaryWithoutPathExpansion(crx_id, &whitelist_dict);
+  base::DictionaryValue* whitelist_dict_weak = nullptr;
+  const bool newly_added = !pref_dict->GetDictionaryWithoutPathExpansion(
+      crx_id, &whitelist_dict_weak);
   if (newly_added) {
-    whitelist_dict = new base::DictionaryValue;
+    auto whitelist_dict = base::MakeUnique<base::DictionaryValue>();
+    whitelist_dict_weak = whitelist_dict.get();
     whitelist_dict->SetString(kName, name);
-    pref_dict->SetWithoutPathExpansion(crx_id, whitelist_dict);
+    pref_dict->SetWithoutPathExpansion(crx_id, std::move(whitelist_dict));
   }
 
   if (!client_id.empty()) {
-    base::ListValue* clients = nullptr;
-    if (!whitelist_dict->GetList(kClients, &clients)) {
+    base::ListValue* clients_weak = nullptr;
+    if (!whitelist_dict_weak->GetList(kClients, &clients_weak)) {
       DCHECK(newly_added);
-      clients = new base::ListValue;
-      whitelist_dict->Set(kClients, clients);
+      auto clients = base::MakeUnique<base::ListValue>();
+      clients_weak = clients.get();
+      whitelist_dict_weak->Set(kClients, std::move(clients));
     }
-    bool success =
-        clients->AppendIfNotPresent(base::MakeUnique<base::Value>(client_id));
+    bool success = clients_weak->AppendIfNotPresent(
+        base::MakeUnique<base::Value>(client_id));
     DCHECK(success);
   }
 
   if (!newly_added) {
     // Sanity-check that the stored name is equal to the name passed in.
     // In release builds this is a no-op.
     std::string stored_name;
-    DCHECK(whitelist_dict->GetString(kName, &stored_name));
+    DCHECK(whitelist_dict_weak->GetString(kName, &stored_name));
     DCHECK_EQ(stored_name, name);
     return;
   }
 
   RegisterNewComponent(crx_id, name);
 }
 
 void SupervisedUserWhitelistInstallerImpl::UnregisterWhitelist(
     const std::string& client_id,
     const std::string& crx_id) {
@@ skipping 75 matching lines @@
 
 // static
 void SupervisedUserWhitelistInstaller::TriggerComponentUpdate(
     OnDemandUpdater* updater,
     const std::string& crx_id) {
   // TODO(sorin): use a callback to check the result (crbug.com/639189).
   updater->OnDemandUpdate(crx_id, component_updater::Callback());
 }
 
 }  // namespace component_updater