Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2811643004: Added missing canonicalization of typedef signature instantiated during (Closed)

Created:
3 years, 8 months ago by regis
Modified:
3 years, 8 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Added missing canonicalization of typedef signature instantiated during finalization (fixes #29300). R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/820f8d74e690ca48bcdc3f3b79c3d2def1bf7779

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M runtime/vm/class_finalizer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/object.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
regis
3 years, 8 months ago (2017-04-10 21:52:21 UTC) #2
siva
lgtm
3 years, 8 months ago (2017-04-10 22:09:23 UTC) #3
regis
3 years, 8 months ago (2017-04-10 22:15:38 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
820f8d74e690ca48bcdc3f3b79c3d2def1bf7779 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698