Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1099)

Unified Diff: third_party/WebKit/Source/platform/text/DecodeEscapeSequences.h

Issue 2811453002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/text (Closed)
Patch Set: fix Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/text/DecodeEscapeSequences.h
diff --git a/third_party/WebKit/Source/platform/text/DecodeEscapeSequences.h b/third_party/WebKit/Source/platform/text/DecodeEscapeSequences.h
index 4cd555b66e25f6eb23ecb8e6f1ac075e00b03be6..ee9fcc13e1e44b8b36e8f7da89ace7d69ac92ab1 100644
--- a/third_party/WebKit/Source/platform/text/DecodeEscapeSequences.h
+++ b/third_party/WebKit/Source/platform/text/DecodeEscapeSequences.h
@@ -139,8 +139,8 @@ struct URLEscapeSequence {
run += 1;
}
}
- ASSERT(
- buffer.size() >=
+ DCHECK_GE(
+ buffer.size(),
static_cast<size_t>(p - buffer.Data())); // Prove buffer not overrun.
return (encoding.IsValid() ? encoding : UTF8Encoding())
.Decode(buffer.Data(), p - buffer.Data());
« no previous file with comments | « third_party/WebKit/Source/platform/text/DateTimeFormatTest.cpp ('k') | third_party/WebKit/Source/platform/text/LocaleICU.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698