Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(785)

Unified Diff: third_party/WebKit/Source/platform/text/DateTimeFormat.cpp

Issue 2811453002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/text (Closed)
Patch Set: fix Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/text/DateTimeFormat.cpp
diff --git a/third_party/WebKit/Source/platform/text/DateTimeFormat.cpp b/third_party/WebKit/Source/platform/text/DateTimeFormat.cpp
index 3e3c0073a79e1de7b508885e4b73ff6ce760dbe1..c0b0b405bebdd030ab17c285737fc7f343127532 100644
--- a/third_party/WebKit/Source/platform/text/DateTimeFormat.cpp
+++ b/third_party/WebKit/Source/platform/text/DateTimeFormat.cpp
@@ -179,9 +179,9 @@ bool DateTimeFormat::Parse(const String& source, TokenHandler& token_handler) {
break;
case kStateSymbol: {
- ASSERT(field_type != kFieldTypeInvalid);
- ASSERT(field_type != kFieldTypeLiteral);
- ASSERT(literal_buffer.IsEmpty());
+ DCHECK_NE(field_type, kFieldTypeInvalid);
+ DCHECK_NE(field_type, kFieldTypeLiteral);
+ DCHECK(literal_buffer.IsEmpty());
FieldType field_type2 = MapCharacterToFieldType(ch);
if (field_type2 == kFieldTypeInvalid)
@@ -211,7 +211,7 @@ bool DateTimeFormat::Parse(const String& source, TokenHandler& token_handler) {
}
}
- ASSERT(field_type != kFieldTypeInvalid);
+ DCHECK_NE(field_type, kFieldTypeInvalid);
switch (state) {
case kStateLiteral:
@@ -227,13 +227,13 @@ bool DateTimeFormat::Parse(const String& source, TokenHandler& token_handler) {
return false;
case kStateSymbol:
- ASSERT(field_type != kFieldTypeLiteral);
- ASSERT(!literal_buffer.length());
+ DCHECK_NE(field_type, kFieldTypeLiteral);
+ DCHECK(!literal_buffer.length());
token_handler.VisitField(field_type, field_counter);
return true;
}
- ASSERT_NOT_REACHED();
+ NOTREACHED();
return false;
}

Powered by Google App Engine
This is Rietveld 408576698