Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issue 281143002: Always inline SkFloatToFixed_arm. (Closed)

Created:
6 years, 7 months ago by Tom Hudson
Modified:
6 years, 7 months ago
Reviewers:
reed1, mtklein, tomhudson
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Always inline SkFloatToFixed_arm. We have "inline" assembly for speed on ARM, but the compiler when told to optimize for space wasn't inlining it, destroying any possible performance improvement. BUG=skbug:2550 R=reed@google.com,mtklein@google.com Committed: http://code.google.com/p/skia/source/detail?r=14745

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M include/core/SkFixed.h View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
tomhudson
Confirmed by inspection that using SK_ALWAYS_INLINE for SkFloatToFixed_arm in Chromium gets rid of those bl ...
6 years, 7 months ago (2014-05-14 15:17:52 UTC) #1
reed1
lgtm
6 years, 7 months ago (2014-05-14 15:18:28 UTC) #2
reed1
hopefully we also have a micro-bench to confirm that SkFloatToFixed_arm is indeed faster than just ...
6 years, 7 months ago (2014-05-14 15:19:21 UTC) #3
mtklein
Was just thinking yesterday that we should take a survey of all the places we ...
6 years, 7 months ago (2014-05-14 15:20:17 UTC) #4
reed1
lgtm
6 years, 7 months ago (2014-05-14 15:35:16 UTC) #5
tomhudson
The CQ bit was checked by tomhudson@google.com
6 years, 7 months ago (2014-05-15 09:39:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/tomhudson@chromium.org/281143002/1
6 years, 7 months ago (2014-05-15 09:39:57 UTC) #7
commit-bot: I haz the power
6 years, 7 months ago (2014-05-15 09:46:22 UTC) #8
Message was sent while issue was closed.
Change committed as 14745

Powered by Google App Engine
This is Rietveld 408576698